This is an archive of the discontinued LLVM Phabricator instance.

[llvm-ar][test] add special case of replace converting a regular to a thin archive
ClosedPublic

Authored by bd1976llvm on May 17 2022, 6:51 AM.

Download Raw Diff

Details

Reviewers

gbreynoo
MaskRay

Commits

rGc913c5598b02: [llvm-ar][test] add special case of replace converting a regular to a thin…

Summary

Add a regression test for: https://github.com/llvm/llvm-project/issues/55527

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

bd1976llvm created this revision.May 17 2022, 6:51 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 6:51 AM

Herald added a subscriber: rupprecht. · View Herald Transcript

bd1976llvm requested review of this revision.May 17 2022, 6:51 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 6:51 AM

Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript

update diff to a working regression test!

Harbormaster completed remote builds in B164877: Diff 430040.May 17 2022, 8:10 AM

bd1976llvm added a reviewer: gbreynoo.May 18 2022, 4:03 AM

We don't attach PR number to test filenames. That's old practice which has been abandoned.
You can add the bug number to the body of the file if necessary, though nn this case I'd say not necessary.

This revision is now accepted and ready to land.May 18 2022, 3:01 PM

Herald added a subscriber: StephenFan. · View Herald TranscriptMay 18 2022, 3:01 PM

(issue 55527)

The subject does not need to duplicate the information in the commit message body.

bd1976llvm retitled this revision from [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527) to [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive.May 27 2022, 2:53 AM

Sorry for the delay. I wanted to wait until https://github.com/llvm/llvm-project/issues/55527 was fully understood in case we needed to adjust the test or add extra cases.

I have addressed the review comments now. Thanks.

bd1976llvm retitled this revision from [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive to [llvm-ar][test] test special case of replace converting a regular to a thin archive.May 27 2022, 3:04 AM

bd1976llvm retitled this revision from [llvm-ar][test] test special case of replace converting a regular to a thin archive to [llvm-ar][test] add special case of replace converting a regular to a thin archive.

This revision was landed with ongoing or failed builds.May 27 2022, 3:08 AM

Closed by commit rGc913c5598b02: [llvm-ar][test] add special case of replace converting a regular to a thin… (authored by Ben Dunbobbin <Ben.Dunbobbin@sony.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Ben Dunbobbin <Ben.Dunbobbin@sony.com> added a commit: rGc913c5598b02: [llvm-ar][test] add special case of replace converting a regular to a thin….

Harbormaster completed remote builds in B166612: Diff 432508.May 27 2022, 3:37 AM

Revision Contents

Path

Size

llvm/

test/

tools/

llvm-ar/

regular-to-thin-archive-special.test

15 lines

Diff 432510

llvm/test/tools/llvm-ar/regular-to-thin-archive-special.test

This file was added.

				## Test regular archives do not convert to thin archives
				## in the special case of replacing a single file in an
				## archive with itself from the current directory.

				# RUN: rm -rf %t && mkdir -p %t && cd %t
				# RUN: echo "a" > a.txt
				# RUN: llvm-ar --format=gnu cr foo.a a.txt 2>&1

				## Check that an error is issued.
				# RUN: not llvm-ar --format=gnu cr --thin foo.a a.txt 2>&1 \| FileCheck %s
				# CHECK: error: cannot convert a regular archive to a thin one

				## Check that the archive is still the correct flavor.
				# RUN: FileCheck --input-file=foo.a %s --check-prefix=REGULAR
				# REGULAR: !<arch>