This is an archive of the discontinued LLVM Phabricator instance.

[mlir][bufferize][NFC] Update One-Shot Bufferize pass documentation
ClosedPublic

Authored by springerm on May 15 2022, 10:38 AM.

Diff Detail

Event Timeline

springerm created this revision.May 15 2022, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 10:38 AM
springerm requested review of this revision.May 15 2022, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 10:38 AM
tpopp accepted this revision.May 20 2022, 3:19 AM
tpopp added inline comments.
mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.td
217–219

Is it okay for the function to destructively modify its inputs without being a configurable flag?

This revision is now accepted and ready to land.May 20 2022, 3:19 AM
springerm marked an inline comment as done.May 20 2022, 7:50 AM
springerm added inline comments.
mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.td
217–219

We analyze function call graphs and insert a buffer copy at the call site if needed. But this could be a problem if the function is called from an external function that we do not bufferize ourselves. Then we can't insert anything at the call site. We could add a configurable flag for this behavior. The current bufferization also has a bufferization.writable = "false" flag that can be added to function args and deactivates in-place writes to that particular tensor.

springerm marked an inline comment as done.May 23 2022, 9:47 AM