[BOLT][TEST] Fix testing on macos

[Amir]

Summary

• Fix common (arch-independent) tests to explicitly target -linux triple.
• Override the triple inside arch-specific tests.
• Add cflags to common tests.
• Update individual tests.
• Expand pipe stderr |& shorthand.

[Amir]

Update

[Amir]

Add missing -nostdlib to arch-independent tests

[rafauler]

Thanks

bolt/test/AArch64/go_dwarf.test

 # Check that the llvm-bolt update the dwarf information correctly in case:
 #  - DW_AT_low_pc is nullified in case the DW_AT_ranges tag already exists.
 #  - DW_AT_high_pc is in the form of DW_FORM_addr.
 
 RUN: yaml2obj %p/Inputs/go_dwarf.yaml &> %t.exe
 RUN: llvm-bolt %t.exe -o %t.bolt -update-debug-sections
 
 # Check the original binary values.
-RUN: llvm-dwarfdump -debug-info %t.exe |& \
+RUN: llvm-dwarfdump -debug-info %t.exe 2>&1 | \
 RUN:   FileCheck %s -check-prefix=CHECKORIG
 
 CHECKORIG:         DW_TAG_compile_unit
 CHECKORIG-NEXT:        DW_AT_producer
 CHECKORIG-NEXT:        DW_AT_language
 CHECKORIG-NEXT:        DW_AT_name
 CHECKORIG-NEXT:        DW_AT_comp_dir
 CHECKORIG-NEXT:        DW_AT_ranges      (0x00000000
 CHECKORIG-NEXT:           [0x0000000000000660, 0x0000000000000684))
 CHECKORIG-NEXT:        DW_AT_low_pc      (0x0000000000000660)
 
 CHECKORIG:         DW_TAG_subprogram
 CHECKORIG-NEXT:        DW_AT_external  (true)
 CHECKORIG-NEXT:        DW_AT_name      ("main")
 CHECKORIG-NEXT:        DW_AT_decl_file
 CHECKORIG-NEXT:        DW_AT_decl_line (1)
 CHECKORIG-NEXT:        DW_AT_decl_column       (0x05)
 CHECKORIG-NEXT:        DW_AT_type
 CHECKORIG-NEXT:        DW_AT_low_pc    (0x0000000000000660)
 CHECKORIG-NEXT:        DW_AT_high_pc   (0x0000000000000684)
 
 
 # Check the bolted binary.
-RUN: llvm-dwarfdump -debug-info %t.bolt |& FileCheck %s
+RUN: llvm-dwarfdump -debug-info %t.bolt 2>&1 | FileCheck %s
 
 CHECK:         DW_TAG_compile_unit
 CHECK-NEXT:        DW_AT_producer
 CHECK-NEXT:        DW_AT_language
 CHECK-NEXT:        DW_AT_name
 CHECK-NEXT:        DW_AT_comp_dir
 CHECK-NEXT:        DW_AT_ranges      (0x00000010
 CHECK-NEXT:           [0x0000000000000660, 0x0000000000000684))

bolt/test/AArch64/lit.local.cfg

 if 'AArch64' not in config.root.targets:
     config.unsupported = True
 
-config.substitutions.insert(
-    0, ('%cflags',
-        '%cflags --target=aarch64-pc-linux -nostartfiles -nostdlib -fuse-ld=lld'
-        ' -ffreestanding -Wl,--unresolved-symbols=ignore-all'))
+flags = '--target=aarch64-pc-linux -nostartfiles -nostdlib -ffreestanding'
 
-config.substitutions.insert(
-    0, ('%cxxflags',
-        '%cxxflags --target=aarch64-pc-linux -nostartfiles -nostdlib -fuse-ld=lld'
-        ' -ffreestanding -Wl,--unresolved-symbols=ignore-all'))
+config.substitutions.insert(0, ('%cflags', f'%cflags {flags}'))
+config.substitutions.insert(0, ('%cxxflags', f'%cxxflags {flags}'))

bolt/test/Inputs/jump_table_icp.cpp

-#include <stdio.h>
-#include <stdlib.h>
+#include "stub.h"
 
 int total = 0;
 
 int inc(int x) {
   switch (x) {
     case 0: total += 1 + 0; return 1;
     case 1: total += 1 + 1; return 2;
     case 2: total += 1 + 2; return 3;

bolt/test/Inputs/stub.h

 #ifndef BOLT_TEST_STUB_H
 #define BOLT_TEST_STUB_H
 
 void *memcpy(void *dest, const void *src, unsigned long n);
 void *memset(void *dest, int c, unsigned long n);
 int printf(const char *format, ...);
 void exit(int status);
 int puts(const char *s);
+int rand(void);
 
 #endif

bolt/test/Inputs/stub.c

 // The stub symbols library used for testing purposes
 
 void *memcpy(void *dest, const void *src, unsigned long n) { return 0; }
 void *memset(void *dest, int c, unsigned long n) { return 0; }
 int printf(const char *format, ...) { return 0; }
 void exit(int status) {}
 int puts(const char *s) { return 0; }
+int rand(void) { return 0; }
 
 void *__gxx_personality_v0;
 void *__cxa_allocate_exception;
 void *_ZTIi;
 void *__cxa_throw;
 void *__cxa_begin_catch;
 void *__cxa_end_catch;

bolt/test/R_ABS.pic.lld.cpp

 /*
  * Check that we don't assert on a duplicate static relocation added by lld
  * against _Z6myfuncv. The same address has a dynamic relocation against it.
  *
- * RUN: %clang -fPIC -shared %s -o %t.so -Wl,-q -fuse-ld=lld
+ * RUN: %clang %cflags -nostdlib -fPIC -shared %s -o %t.so -Wl,-q
  * RUN: llvm-bolt %t.so -o %t.so.bolt -relocs
  */
 
 unsigned long long myfunc();
 
 unsigned long long (*myglobal)() = myfunc;
 
 unsigned long long myfunc() {
   return reinterpret_cast<unsigned long long>(myglobal);
 }

bolt/test/X86/Inputs/avx512.c

-void use_avx512() {
-  asm (".byte 0x62, 0xe2, 0xf5, 0x70, 0x2c, 0xda");
-  asm("secondary_entry:");
-}
-
-int main() {
-  use_avx512();
-
-  return 0;
-}

bolt/test/X86/Inputs/avx512.s

+.globl use_avx512
+use_avx512:
+  pushq   %rbp
+  movq    %rsp, %rbp
+  vscalefpd       {rz-sae}, %zmm2, %zmm17, %zmm19
+secondary_entry:
+  popq    %rbp
+  retq
+  nopl    (%rax)
+
+.globl main
+main:
+  pushq   %rbp
+  movq    %rsp, %rbp
+  subq    $16, %rsp
+  movl    $0, -4(%rbp)
+  callq   use_avx512
+  xorl    %eax, %eax
+  addq    $16, %rsp
+  popq    %rbp
+  retq

bolt/test/X86/avx512-trap.test

 # Check that BOLT inserts trap instruction at entry to functions that use AVX-512.
 # Check that AVX-512 instruction is updated correctly when -trap-avx512=0 is passed.
 
-RUN: %clang %cflags %S/Inputs/avx512.c -o %t -Wl,-q,-znow
-RUN: llvm-bolt %t -trap-avx512=1 -o %t.bolt 2>&1 | FileCheck %s && \
-RUN:    llvm-objdump -d --disassemble-symbols=use_avx512 %t.bolt | FileCheck %s --check-prefix=CHECK-DIS
-RUN: llvm-bolt %t -trap-avx512=0 -o %t.bolt && \
-RUN:    llvm-objdump -d --disassemble-symbols=use_avx512 %t.bolt | FileCheck %s --check-prefix=CHECK-DIS-NO-TRAP
+RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-unknown -o %t.o \
+RUN:   %S/Inputs/avx512.s
+RUN: ld.lld %t.o -o %t -q
+RUN: llvm-objdump -d --disassemble-symbols=use_avx512 %t | \
+RUN:   FileCheck %s --check-prefix=CHECK-DIS-NO-TRAP
+
+RUN: llvm-bolt %t -trap-avx512=1 -o %t.bolt -lite=0 2>&1 | FileCheck %s
+RUN: llvm-objdump -d --disassemble-symbols=use_avx512 %t.bolt | \
+RUN:   FileCheck %s --check-prefix=CHECK-DIS
+
+RUN: llvm-bolt %t -trap-avx512=0 -o %t.bolt -lite=0
+RUN: llvm-objdump -d --disassemble-symbols=use_avx512 %t.bolt | \
+RUN:   FileCheck %s --check-prefix=CHECK-DIS-NO-TRAP
 
 CHECK: BOLT-WARNING: 1 function will trap on entry
 
 # Check that we have two ud2 instructions - one per entry.
 CHECK-DIS:      use_avx512
 CHECK-DIS-NEXT:    ud2
 CHECK-DIS-NEXT:    ud2
 
 # Check that we generate correct AVX-512
 CHECK-DIS-NO-TRAP:      use_avx512
 CHECK-DIS-NO-TRAP:          62 e2 f5 70 2c da     vscalefpd 

bolt/test/X86/indirect-goto.test

 # Check llvm-bolt processes binaries compiled from sources that use indirect goto.
 RUN: %clang %cflags -no-pie %S/Inputs/indirect_goto.c -Wl,-q -o %t
 RUN: llvm-bolt %t -o /dev/null -relocs=1 -print-cfg -print-only=main -strict \
-RUN:   |& FileCheck %s
+RUN:   2>&1 | FileCheck %s
 
 # Check that all possible destinations are included as successors.
 CHECK:  jmpq    *%rax # UNKNOWN CONTROL FLOW
 CHECK:  Successors: .Ltmp0, .Ltmp1, .Ltmp2

bolt/test/X86/lit.local.cfg

 if not 'X86' in config.root.targets:
     config.unsupported = True
 
-config.substitutions.insert(
-    0, ('%cflags',
-        '%cflags --target=x86_64--pc-linux -nostdlib -fuse-ld=lld'
-        ' -Wl,--unresolved-symbols=ignore-all'))
+flags = '--target=x86_64-pc-linux -nostdlib'
 
-config.substitutions.insert(
-    0, ('%cxxflags',
-        '%cxxflags --target=x86_64--pc-linux -nostdlib -fuse-ld=lld'
-        ' -Wl,--unresolved-symbols=ignore-all'))
+config.substitutions.insert(0, ('%cflags', f'%cflags {flags}'))
+config.substitutions.insert(0, ('%cxxflags', f'%cxxflags {flags}'))

bolt/test/X86/relaxed-tailcall.test

 # Check that tail calls can be 2 bytes in the output binary.
 
-RUN: %clang %cflags %S/Inputs/relaxed_tc.s -o %t.exe -Wl,-q
+RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-unknown -o %t.o \
+RUN:   %S/Inputs/relaxed_tc.s
+RUN: ld.lld %t.o -o %t.exe -q
 RUN: llvm-bolt %t.exe -relocs -o %t
 RUN: llvm-objdump -d --disassemble-symbols=foo %t | FileCheck %s
 
 CHECK: eb 00 jmp {{.*}} <bar>

bolt/test/X86/static-exe.test

 # Check that llvm-bolt can rewrite static executable
 
 RUN: %clang %cflags %S/Inputs/static_exe.s -static -o %t.exe -nostdlib
-RUN: llvm-bolt %t.exe -o %t |& FileCheck %s
+RUN: llvm-bolt %t.exe -o %t 2>&1 | FileCheck %s
 
 CHECK: 1 out of 1 functions were overwritten

bolt/test/bad-exe.test

 # Check that llvm-bolt rejects input that is not a valid ELF executable
 # bzip2.debuginfo is the result of running "objcopy --only-keep-debug".
-RUN: %clang %S/Inputs/icf-jump-tables.c -g -o %t
+RUN: %clang %cflags -nostdlib %S/Inputs/icf-jump-tables.c -g -o %t
 RUN: llvm-objcopy --only-keep-debug %t %t.debuginfo
-RUN: not llvm-bolt %t.debuginfo -o /dev/null |& FileCheck %s
+RUN: not llvm-bolt %t.debuginfo -o /dev/null 2>&1 | FileCheck %s
 
 CHECK: input binary is not a valid ELF executable

bolt/test/bolt-info.test

 # Check that the .bolt_info section is generated properly.
-RUN: %clang %S/Inputs/icf-jump-tables.c -o %t
+RUN: %clang %cflags -nostdlib %S/Inputs/icf-jump-tables.c -o %t
 RUN: llvm-bolt %t -o %t.bolt && \
 RUN: llvm-objdump -s -j .note.bolt_info %t.bolt | grep -v "file format" | \
 RUN:   cut -c 44- | tr -d '\n' | FileCheck %s
 
 CHECK: BOLT revision: {{.*}}, command line: {{.*}}llvm-bolt {{.*}}/bolt-info.test.tmp -o {{.*}}/bolt-info.test.tmp.bolt

bolt/test/invalid-profile.test

 # Check that llvm-bolt detects bad profile data and aborts
 
 RUN: %clang %S/Inputs/icf-jump-tables.c -o %t
-RUN: not llvm-bolt %t -o %t.bolt -data %t |& FileCheck %s
+RUN: not llvm-bolt %t -o %t.bolt -data %t 2>&1 | FileCheck %s
 
 CHECK: no valid profile data found

bolt/test/lit.local.cfg

+host_linux_triple = config.target_triple.split('-')[0]+'-linux'
+common_linker_flags = '-fuse-ld=lld -Wl,--unresolved-symbols=ignore-all'
+flags = f'--target={host_linux_triple} {common_linker_flags}'
+
+config.substitutions.insert(0, ('%cflags', f'%cflags {flags}'))
+config.substitutions.insert(0, ('%cxxflags', f'%cxxflags {flags}'))

bolt/test/no-relocs.test

 # Verifies that input without relocations is rejected in relocs mode.
 
-RUN: %clang %S/Inputs/icf-jump-tables.c -o %t
+RUN: %clang %cflags -nostdlib %S/Inputs/icf-jump-tables.c -o %t
 RUN: not llvm-bolt %t -o /dev/null -relocs 2>&1 | FileCheck %s
 
 CHECK: BOLT-ERROR: relocations against code are missing from the input file.

bolt/test/pie.test

 # Check that we do not reject position-independent executables (PIEs).
 
-RUN: %clang -fPIC -pie %p/Inputs/jump_table_icp.cpp -o %t
+RUN: %clang %cflags -nostdlib -fPIC -pie %p/Inputs/jump_table_icp.cpp -o %t
 RUN: llvm-bolt %t -o /dev/null 2>&1 | FileCheck %s
 
 CHECK: BOLT-INFO: shared object or position-independent executable detected

bolt/test/re-optimize.test

 # Check that we detect re-optimization attempt.
 
-RUN: %clang %S/Inputs/icf-jump-tables.c -o %t.exe
+RUN: %clang %cflags -nostdlib %S/Inputs/icf-jump-tables.c -o %t.exe
 RUN: llvm-bolt %t.exe -o %t 2>&1 > /dev/null
 RUN: not llvm-bolt %t -o %t.bolt 2>&1 | FileCheck %s
 
 CHECK: BOLT-ERROR: input file was processed by BOLT. Cannot re-optimize.

bolt/test/shared-object.test

 # Test that llvm-bolt processes *.so without a failure
-RUN: %clang %S/Inputs/icf-jump-tables.c -o %t.so -shared -fPIC -Wl,--build-id
+RUN: %clang %cflags -nostdlib %S/Inputs/icf-jump-tables.c -o %t.so -shared -fPIC -Wl,--build-id
 RUN: llvm-bolt %t.so -o %t | FileCheck %s
 
 CHECK: patched build-id