This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Tablegen-LSP] Add support for include file link and hover
ClosedPublic

Authored by rriddle on May 11 2022, 8:01 PM.

Details

Summary

This allows for following links to include files. This support is effectively
identical to the logic in the PDLL language server, and code is shared as
much as possible.

Diff Detail

Event Timeline

rriddle created this revision.May 11 2022, 8:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 8:01 PM
rriddle requested review of this revision.May 11 2022, 8:01 PM
rriddle updated this revision to Diff 429627.May 16 2022, 12:40 AM
rriddle edited the summary of this revision. (Show Details)
jpienaar accepted this revision.May 25 2022, 10:46 AM
jpienaar added inline comments.
mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp
102

Do we have to worry about something like \\" ?

This revision is now accepted and ready to land.May 25 2022, 10:46 AM
rriddle marked an inline comment as done.May 27 2022, 1:31 AM
rriddle added inline comments.
mlir/lib/Tools/lsp-server-support/SourceMgrUtils.cpp
102

" is not a valid windows path character, so I don't think we'll ever see it in the places that we care about here.

This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.