This is an archive of the discontinued LLVM Phabricator instance.

[flang] Upstream fix for performance issue
ClosedPublic

Authored by schweitz on May 10 2022, 1:32 PM.

Details

Summary

Lowering of assignments in forall constructs could result in too many temporaries and copies. These changes eliminate this duplication.

Diff Detail

Event Timeline

schweitz created this revision.May 10 2022, 1:32 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 10 2022, 1:32 PM
schweitz requested review of this revision.May 10 2022, 1:32 PM
schweitz updated this revision to Diff 428487.May 10 2022, 1:34 PM
PeteSteinfeld accepted this revision.May 10 2022, 2:09 PM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.May 10 2022, 2:09 PM
jeanPerier accepted this revision.May 11 2022, 1:13 AM

clang-format should be run on lib/Lower/ConvertExpr.cpp, otherwise LGTM.

schweitz updated this revision to Diff 428671.May 11 2022, 8:23 AM

Fixes clang-format issues on the entire file.

schweitz updated this revision to Diff 428676.May 11 2022, 8:29 AM