This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Skip extra round-trip in parsing args in debug builds. NFC
ClosedPublic

Authored by sammccall on May 7 2022, 8:32 AM.

Details

Summary

This is a clever cross-cutting sanity test for clang's arg parsing I suppose.
But clangd creates thousands of invocations, ~all with identical trivial
arguments, and problems with these would be caught by clang's tests.
This overhead accounts for 10% of total unittest time!

Diff Detail

Event Timeline

sammccall created this revision.May 7 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2022, 8:32 AM
sammccall requested review of this revision.May 7 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2022, 8:32 AM
This revision is now accepted and ready to land.May 9 2022, 2:30 AM