This is an archive of the discontinued LLVM Phabricator instance.

Add opaque ptr to the llvm-c
AbandonedPublic

Authored by deadalnix on May 7 2022, 8:25 AM.

Details

Reviewers
lerno
nikic
aeubanks
Group Reviewers
Restricted Project
Summary

Add wrappers to allow use of opaque pointers from the C API

Diff Detail

Event Timeline

lerno created this revision.May 7 2022, 8:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
lerno requested review of this revision.May 7 2022, 8:25 AM
deadalnix requested changes to this revision.May 7 2022, 8:37 AM

This is lacking a test. The LLVM C API is typically tested using the echo test (a program that read LLVM IR with the LLVM C API, and the re-emit it, and it can be checked that both are equal).

llvm/include/llvm-c/Core.h
1541

Considering that using things without context is deprecated, maybe we can skip this one.

This revision now requires changes to proceed.May 7 2022, 8:37 AM
nikic added a reviewer: Restricted Project.May 7 2022, 8:47 AM
lerno updated this revision to Diff 427880.May 7 2022, 10:49 AM

Removed the default context method.

lerno added a comment.May 7 2022, 10:53 AM

Note that I'm not really having a good environment to work on LLVM. I can submit changes I've tested to work with my frontend, but I don't know much about the unit tests in LLVM. If you don't want to accept this change because of the missing the tests, then perhaps we could have someone look at adding the tests?

nikic resigned from this revision.May 17 2022, 12:54 AM
nikic added a subscriber: nikic.

This has been superseded by D125183.

aeubanks resigned from this revision.May 19 2022, 1:44 PM
deadalnix commandeered this revision.May 23 2023, 4:44 PM
deadalnix edited reviewers, added: lerno; removed: deadalnix.
deadalnix abandoned this revision.May 23 2023, 4:44 PM