Page MenuHomePhabricator

nico-abram (Nicolas Abram)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2022, 10:34 PM (9 w, 5 d)

Recent Activity

May 14 2022

nico-abram added a comment to D125183: Add opaque pointers to the llvm-c API.

I don't have commit rights, could somebody please land this for me?

May 14 2022, 7:02 AM · Restricted Project, Restricted Project

May 13 2022

nico-abram updated the diff for D125183: Add opaque pointers to the llvm-c API.

Thanks for the feedback.

May 13 2022, 5:11 PM · Restricted Project, Restricted Project

May 10 2022

nico-abram added inline comments to D125183: Add opaque pointers to the llvm-c API.
May 10 2022, 3:27 PM · Restricted Project, Restricted Project

May 8 2022

nico-abram updated the diff for D125183: Add opaque pointers to the llvm-c API.

Addressed @nikic's comments, thanks for the feedback.

May 8 2022, 2:26 AM · Restricted Project, Restricted Project

May 7 2022

nico-abram requested review of D125183: Add opaque pointers to the llvm-c API.
May 7 2022, 11:42 PM · Restricted Project, Restricted Project

May 2 2022

nico-abram abandoned D124722: [InstCombine] extract(u[add|sub].with.overflow(X, C), 0) --> [add|sub](X, C).

Abandoning revision since the transformation is not safe.

May 2 2022, 5:56 PM · Restricted Project, Restricted Project

Apr 30 2022

nico-abram updated the summary of D124722: [InstCombine] extract(u[add|sub].with.overflow(X, C), 0) --> [add|sub](X, C).
Apr 30 2022, 11:58 PM · Restricted Project, Restricted Project
nico-abram updated the diff for D124722: [InstCombine] extract(u[add|sub].with.overflow(X, C), 0) --> [add|sub](X, C).
Apr 30 2022, 11:57 PM · Restricted Project, Restricted Project
nico-abram updated the diff for D124722: [InstCombine] extract(u[add|sub].with.overflow(X, C), 0) --> [add|sub](X, C).
Apr 30 2022, 11:56 PM · Restricted Project, Restricted Project
nico-abram requested review of D124722: [InstCombine] extract(u[add|sub].with.overflow(X, C), 0) --> [add|sub](X, C).
Apr 30 2022, 4:15 PM · Restricted Project, Restricted Project

Apr 27 2022

nico-abram added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.
  • A debug build on Windows using MSVC can take around 70 to roughly 100 GB of storage space, which are always surprising and may also lead to out of disk space errors. Release builds are comparatively just a few Gigabytes. I believe they are also multiply tens of Gigabytes on other OSs
Apr 27 2022, 12:43 PM · Restricted Project, Restricted Project
nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

Addressed comments, I kept the lambda.

Apr 27 2022, 9:58 AM · Restricted Project, Restricted Project
nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

Rebased

Apr 27 2022, 9:08 AM · Restricted Project, Restricted Project
nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

Updated the patch with update_test_checks.py run with the changes applied on top of https://reviews.llvm.org/rGfd9026131e6c5de6f4e582d5c85c5b5588672dfb
Looks like what I'd expect. It's optimizing it through the opaque use call, but that doesn't look like a problem to me.

Apr 27 2022, 8:04 AM · Restricted Project, Restricted Project

Apr 26 2022

nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

Updated the diff with the 2 tests to ensure the opt is not applied on non-exact ashr/lshr ashr_add_negative_shift_no_exact and lshr_add_negative_shift_no_exact.

Apr 26 2022, 4:42 PM · Restricted Project, Restricted Project

Apr 25 2022

nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

I collapsed all three into InstCombinerImpl::commonShiftTransforms, right below the pre-existing pre-shift combine.

Apr 25 2022, 2:07 PM · Restricted Project, Restricted Project
nico-abram updated the diff for D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.

Updating the diff with the condition change and more tests. Will see about avoiding the duplication and moving into commonShiftTransforms

Apr 25 2022, 12:10 PM · Restricted Project, Restricted Project
nico-abram added a comment to D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.
  1. Please write a more general proof for these transforms. See examples in the comments here: https://github.com/llvm/llvm-project/issues/54890
  2. Does the lshr transform require "exact" or not?
Apr 25 2022, 11:21 AM · Restricted Project, Restricted Project
nico-abram requested review of D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X.
Apr 25 2022, 2:52 AM · Restricted Project, Restricted Project