- User Since
- Apr 24 2022, 10:34 PM (84 w, 4 d)
May 14 2022
I don't have commit rights, could somebody please land this for me?
May 13 2022
Thanks for the feedback.
May 10 2022
May 8 2022
Addressed @nikic's comments, thanks for the feedback.
May 7 2022
May 2 2022
Abandoning revision since the transformation is not safe.
Apr 30 2022
Apr 27 2022
Addressed comments, I kept the lambda.
Updated the patch with update_test_checks.py run with the changes applied on top of https://reviews.llvm.org/rGfd9026131e6c5de6f4e582d5c85c5b5588672dfb
Looks like what I'd expect. It's optimizing it through the opaque use call, but that doesn't look like a problem to me.
Apr 26 2022
Updated the diff with the 2 tests to ensure the opt is not applied on non-exact ashr/lshr ashr_add_negative_shift_no_exact and lshr_add_negative_shift_no_exact.
Apr 25 2022
I collapsed all three into InstCombinerImpl::commonShiftTransforms, right below the pre-existing pre-shift combine.
Updating the diff with the condition change and more tests. Will see about avoiding the duplication and moving into commonShiftTransforms