Page MenuHomePhabricator

lerno (Christoffer Lerno)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2021, 12:34 AM (101 w, 3 h)

Recent Activity

Aug 11 2022

lerno added a comment to D129478: [IR] Remove support for float binop constant expressions.

Note that this change (and related changes) is nuking a huge amount of non-deprecated C API functions. It suggests using the LLVMBuild* versions, but those do not work without instantiating a builder, which typically does not exist on the global level. Allowing the user of the API to pass in a NULL builder would have made it more palatable, but as is the option is either to create a dummy builder for the global level (which isn't actually used! It's just to satisfy the contract of the LLVMBuild* functions) or try to do constant folding in the frontend. In addition the removal it also breaks all LLVM-C based bridges in other languages.

Aug 11 2022, 7:30 AM · Restricted Project, Restricted Project

May 7 2022

lerno added a comment to D125168: Add opaque ptr to the llvm-c.

Note that I'm not really having a good environment to work on LLVM. I can submit changes I've tested to work with my frontend, but I don't know much about the unit tests in LLVM. If you don't want to accept this change because of the missing the tests, then perhaps we could have someone look at adding the tests?

May 7 2022, 10:53 AM · Restricted Project, Restricted Project
lerno updated the diff for D125168: Add opaque ptr to the llvm-c.

Removed the default context method.

May 7 2022, 10:49 AM · Restricted Project, Restricted Project
lerno requested review of D125168: Add opaque ptr to the llvm-c.
May 7 2022, 8:25 AM · Restricted Project, Restricted Project

Mar 2 2021

lerno added a comment to D97763: Add type attributes to LLVM C API.

Just so I understand @arsenm: are API unit tests needed to approve this pull request? If so, who is planning on adding them? I mean the C API as it currently works cannot even correctly provide byval and sret according to spec.

Mar 2 2021, 7:31 AM · Restricted Project
lerno added a comment to D97763: Add type attributes to LLVM C API.

As far as I know we don't have any C API unit tests, but sorely need them if you want to try adding the first

Mar 2 2021, 5:25 AM · Restricted Project
lerno requested review of D97763: Add type attributes to LLVM C API.
Mar 2 2021, 4:51 AM · Restricted Project