This is an archive of the discontinued LLVM Phabricator instance.

[lld] Fix typo for processAux; NFC
ClosedPublic

Authored by XiaodongLoong on May 7 2022, 4:12 AM.

Diff Detail

Event Timeline

XiaodongLoong created this revision.May 7 2022, 4:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
XiaodongLoong requested review of this revision.May 7 2022, 4:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2022, 4:12 AM
MaskRay accepted this revision.EditedMay 7 2022, 6:34 PM

You need to do git log -- lld/ELF to find the appropriate regular reviewers, instead of adding some folks (who gave you LGTM in the past) for a random component in llvm-project.

In this particular case, it probably doesn't matter as the fix is obvious and nearly everyone can approve the patch, but I am just concerned with changing a random component with an inappropriate reviewer.

This revision is now accepted and ready to land.May 7 2022, 6:34 PM

You need to do git log -- lld/ELF to find the appropriate regular reviewers, instead of adding some folks (who gave you LGTM in the past) for a random component in llvm-project.

In this particular case, it probably doesn't matter as the fix is obvious and nearly everyone can approve the patch, but I am just concerned with changing a random component with an inappropriate reviewer.

OK, you are right. I'll do it as you said.

This revision was automatically updated to reflect the committed changes.