This is an archive of the discontinued LLVM Phabricator instance.

Differential D125068

[libcxx] random_device, use arc4random() on Solaris
ClosedPublic

Authored by brad on May 5 2022, 7:56 PM.

Details

Reviewers
ro
ldionne
Group Reviewers
Restricted Project
Commits
rGed85de6db44e: [libcxx] random_device, use arc4random() on Solaris
Summary

Solaris also has arc4random().

Diff Detail

Event Timeline

brad created this revision.May 5 2022, 7:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 7:56 PM
Herald added subscribers: fedor.sergeev, krytarowski. · View Herald Transcript
brad requested review of this revision.May 5 2022, 7:57 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMay 5 2022, 7:57 PM
Harbormaster completed remote builds in B163059: Diff 427518.May 5 2022, 10:19 PM
ldionne accepted this revision.May 6 2022, 10:09 AM
This revision is now accepted and ready to land.May 6 2022, 10:09 AM
Closed by commit rGed85de6db44e: [libcxx] random_device, use arc4random() on Solaris (authored by brad). · Explain WhyMay 6 2022, 10:01 PM
This revision was automatically updated to reflect the committed changes.
brad added a commit: rGed85de6db44e: [libcxx] random_device, use arc4random() on Solaris.

Revision Contents

PathSize
libcxx/
docs/
4 lines
include/
2 lines

Diff 427518

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 96 Lines • ▼ Show 20 Lines
ABI Changes ABI Changes
----------- -----------
- The ``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` macro controlling whether we use an - The ``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` macro controlling whether we use an
emulation for ``std::nullptr_t`` in C++03 mode has been removed. After this change, emulation for ``std::nullptr_t`` in C++03 mode has been removed. After this change,
``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` will not be honoured anymore and there ``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` will not be honoured anymore and there
will be no way to opt back into the C++03 emulation of ``std::nullptr_t``. will be no way to opt back into the C++03 emulation of ``std::nullptr_t``.
- On FreeBSD, NetBSD and DragonFlyBSD, ``std::random_device`` is now implemented on top of - On FreeBSD, NetBSD, DragonFlyBSD and Solaris, ``std::random_device`` is now implemented on
``arc4random()`` instead of reading from ``/dev/urandom``. Any implementation-defined top of ``arc4random()`` instead of reading from ``/dev/urandom``. Any implementation-defined
token used when constructing a ``std::random_device`` will now be ignored instead of token used when constructing a ``std::random_device`` will now be ignored instead of
interpreted as a file to read entropy from. interpreted as a file to read entropy from.
Build System Changes Build System Changes
-------------------- --------------------
- Support for standalone builds have been entirely removed from libc++, libc++abi and - Support for standalone builds have been entirely removed from libc++, libc++abi and
libunwind. Please use :ref:`these instructions <build instructions>` for building libunwind. Please use :ref:`these instructions <build instructions>` for building
Show All 25 Lines

libcxx/include/__config

Show First 20 Lines • Show All 345 Lines • ▼ Show 20 Lines
// When this option is used, the token passed to `std::random_device`'s // When this option is used, the token passed to `std::random_device`'s
// constructor *must* be "/dev/urandom" -- anything else is an error. // constructor *must* be "/dev/urandom" -- anything else is an error.
// //
// _LIBCPP_USING_WIN32_RANDOM // _LIBCPP_USING_WIN32_RANDOM
// Use rand_s(), for use on Windows. // Use rand_s(), for use on Windows.
// When this option is used, the token passed to `std::random_device`'s // When this option is used, the token passed to `std::random_device`'s
// constructor *must* be "/dev/urandom" -- anything else is an error. // constructor *must* be "/dev/urandom" -- anything else is an error.
#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || \ #if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || \
defined(__OpenBSD__) || defined(__DragonFly__) defined(__OpenBSD__) || defined(__DragonFly__) || defined(__sun__)
# define _LIBCPP_USING_ARC4_RANDOM # define _LIBCPP_USING_ARC4_RANDOM
#elif defined(__wasi__) #elif defined(__wasi__)
# define _LIBCPP_USING_GETENTROPY # define _LIBCPP_USING_GETENTROPY
#elif defined(__Fuchsia__) #elif defined(__Fuchsia__)
# define _LIBCPP_USING_FUCHSIA_CPRNG # define _LIBCPP_USING_FUCHSIA_CPRNG
#elif defined(__native_client__) #elif defined(__native_client__)
# define _LIBCPP_USING_NACL_RANDOM # define _LIBCPP_USING_NACL_RANDOM
#elif defined(_LIBCPP_WIN32API) #elif defined(_LIBCPP_WIN32API)
▲ Show 20 Lines • Show All 1,004 Lines • Show Last 20 Lines