This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix max_size.pass.cpp for other Windows architectures
ClosedPublic

Authored by mstorsjo on May 5 2022, 12:20 AM.

Details

Summary

All current Windows architectures (i386, x86_64, arm, arm64) get
the full_size() behaviour here. x86_64 (the only one tested in CI
currently) is handled by the first ifdef at the top, but handle
Windows in general on all other architectures later.

Diff Detail

Event Timeline

mstorsjo created this revision.May 5 2022, 12:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 12:20 AM
mstorsjo requested review of this revision.May 5 2022, 12:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 12:20 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.May 5 2022, 12:23 AM
philnik added a subscriber: philnik.

LGTM assuming CI passes.

This revision is now accepted and ready to land.May 5 2022, 12:23 AM
ldionne accepted this revision.May 5 2022, 8:19 AM