[BOLT][NFC] Make ICP::verifyProfile static

[Amir]

Summary

Follow LLVM style guide suggestion to avoid function definitions in anonymous
namespaces: https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

[Amir]

Remove extra newline

[rafauler]

LGTM

bolt/lib/Passes/IndirectCallPromotion.cpp

static cl::opt<bool> ICPJumpTablesByTarget(
     cl::init(false), cl::ZeroOrMore, cl::Hidden, cl::cat(BoltOptCategory));
 
 static cl::opt<bool> ICPPeelForInline(
     "icp-inline", cl::desc("only promote call targets eligible for inlining"),
     cl::init(false), cl::ZeroOrMore, cl::Hidden, cl::cat(BoltOptCategory));
 
 } // namespace opts
 
-namespace llvm {
-namespace bolt {
-
-namespace {
-
-bool verifyProfile(std::map<uint64_t, BinaryFunction> &BFs) {
+static bool verifyProfile(std::map<uint64_t, BinaryFunction> &BFs) {
   bool IsValid = true;
   for (auto &BFI : BFs) {
     BinaryFunction &BF = BFI.second;
     if (!BF.isSimple())
       continue;
     for (BinaryBasicBlock *BB : BF.layout()) {
       auto BI = BB->branch_info_begin();
       for (BinaryBasicBlock *SuccBB : BB->successors()) {
         if (BI->Count != BinaryBasicBlock::COUNT_NO_PROFILE && BI->Count > 0) {
           if (BB->getKnownExecutionCount() == 0 ||
               SuccBB->getKnownExecutionCount() == 0) {
             errs() << "BOLT-WARNING: profile verification failed after ICP for "
                       "function "
                    << BF << '\n';
             IsValid = false;
           }
         }
         ++BI;
       }
     }
   }
   return IsValid;
 }
 
-} // namespace
+namespace llvm {
+namespace bolt {
 
 IndirectCallPromotion::Callsite::Callsite(BinaryFunction &BF,
                                           const IndirectCallProfile &ICP)
     : From(BF.getSymbol()), To(ICP.Offset), Mispreds(ICP.Mispreds),
       Branches(ICP.Count) {
   if (ICP.Symbol) {
     To.Sym = ICP.Symbol;
     To.Addr = 0;