This is an archive of the discontinued LLVM Phabricator instance.

[MIPS} Address ISel failures for 64 bit fpus in microMIPS
ClosedPublic

Authored by sdardis on Apr 30 2022, 5:12 PM.

Details

Summary

Add the instructions and patterns for loads and stores in microMIPSr3
when a 64 bit FPU is present. Previously, this would lead to an
instruction selection failure.

This resolves PR/49200.

Thanks to jdeguire for reporting the issue!

Diff Detail

Event Timeline

sdardis created this revision.Apr 30 2022, 5:12 PM
sdardis requested review of this revision.Apr 30 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2022, 5:12 PM
sdardis updated this revision to Diff 426257.Apr 30 2022, 5:21 PM

NFC: Remove some extraneous test lines and a small grammar correction

atanasyan added inline comments.May 9 2022, 10:23 PM
llvm/test/CodeGen/Mips/llvm-ir/store.ll
28

Are changes like this unrelated to the fix?

sdardis added inline comments.May 10 2022, 6:25 AM
llvm/test/CodeGen/Mips/llvm-ir/store.ll
28

These are somewhat unrelated but do simply the regexes a bit. I can undo regex style change if youe feel it's necessary.

atanasyan accepted this revision.May 10 2022, 9:23 AM

LGTM

llvm/test/CodeGen/Mips/llvm-ir/store.ll
28

I think about splitting these changes into the two commits. But it's up to you.

This revision is now accepted and ready to land.May 10 2022, 9:23 AM
This revision was landed with ongoing or failed builds.May 12 2022, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the review, @atanasyan . I went with changing the regexes back to the style in the existing file.