This is an archive of the discontinued LLVM Phabricator instance.

Differential D124682

[flang] Fix build bot problem
ClosedPublic

Authored by klausler on Apr 29 2022, 9:31 AM.

Details

Reviewers
jeanPerier
schweitz
vdonaldson
Commits
rG5a7936401c0a: [flang] Fix build bot problem
Summary

A recent change is eliciting a valid warning from the out-of-tree
flang build bot; fix by using a reference in a range-based for().

Diff Detail

Event Timeline

klausler created this revision.Apr 29 2022, 9:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 9:31 AM
Herald added subscribers: mehdi_amini, jdoerfert. · View Herald Transcript
klausler requested review of this revision.Apr 29 2022, 9:31 AM
vdonaldson accepted this revision.Apr 29 2022, 9:42 AM
This revision is now accepted and ready to land.Apr 29 2022, 9:42 AM
Harbormaster completed remote builds in B162015: Diff 426092.Apr 29 2022, 10:55 AM
schweitz accepted this revision.Apr 29 2022, 11:05 AM
Closed by commit rG5a7936401c0a: [flang] Fix build bot problem (authored by klausler). · Explain WhyApr 29 2022, 11:13 AM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG5a7936401c0a: [flang] Fix build bot problem.

Revision Contents

PathSize
flang/
lib/
Lower/
2 lines

Diff 426092

flang/lib/Lower/ConvertVariable.cpp

Context not available.
std::vector<std::tuple<fir::GlobalOp, Fortran::semantics::MutableSymbolVector, std::vector<std::tuple<fir::GlobalOp, Fortran::semantics::MutableSymbolVector,
mlir::Location>> mlir::Location>>
delayedInitializations; delayedInitializations;
for (const auto [common, size] : commonBlocks) for (const auto &[common, size] : commonBlocks)
if (auto delayedInit = declareCommonBlock(converter, common, size)) if (auto delayedInit = declareCommonBlock(converter, common, size))
delayedInitializations.emplace_back(std::move(*delayedInit)); delayedInitializations.emplace_back(std::move(*delayedInit));
for (auto &[global, cmnBlkMems, loc] : delayedInitializations) for (auto &[global, cmnBlkMems, loc] : delayedInitializations)
Context not available.