This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Don't iterate mutable user list
ClosedPublic

Authored by vitalybuka on Apr 27 2022, 5:08 PM.

Details

Summary

executeOp.operandsMutable().append(asyncTokens) in
addAsyncDependencyAfter can resize and invalidate iterators.

Fixes reports like https://reviews.llvm.org/P8286

Diff Detail

Event Timeline

vitalybuka created this revision.Apr 27 2022, 5:08 PM
vitalybuka requested review of this revision.Apr 27 2022, 5:08 PM
vitalybuka edited the summary of this revision. (Show Details)Apr 27 2022, 5:11 PM
herhut accepted this revision.Apr 28 2022, 2:51 AM

Thanks!

This revision is now accepted and ready to land.Apr 28 2022, 2:51 AM
This revision was automatically updated to reflect the committed changes.