This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Fix NVPTX DebugInfo tests on Windows
ClosedPublic

Authored by asavonic on Apr 26 2022, 12:54 PM.

Details

Summary

These tests were added in D121299 and they failed on Windows:

    error: CHECK-NODIR: expected string
    not found in input
    ; CHECK-NODIR: .file {{[0-9]+}} "/tmp/dbginfo/a/a.cpp"
		   ^
    <stdin>:1:1: note: scanning from here
    //
    ^
    <stdin>:25:2: note: possible intended match here
     .file 1 "/tmp/dbginfo/a\\a.cpp"

I don't have a windows machine to test this, but I've seen this {{/|\\\\}}
pattern in other NVPTX tests, so I hope it works.

Diff Detail

Unit TestsFailed

Event Timeline

asavonic created this revision.Apr 26 2022, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 12:54 PM
asavonic requested review of this revision.Apr 26 2022, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 12:54 PM
asavonic updated this revision to Diff 425446.Apr 27 2022, 2:30 AM
asavonic retitled this revision from [NVPTX] Fix dwarf-file-dir.ll on Windows to [NVPTX] Fix NVPTX DebugInfo tests on Windows.
asavonic edited the summary of this revision. (Show Details)
asavonic added a reviewer: thakis.
asavonic added a subscriber: thakis.

I missed two other tests that failed because of the same issue: debug-file-loc.ll and debug-file-loc-only.ll.
@thakis tried to fix them in a1bb5719eca6 (thanks a lot!), but I'm not sure if it helped - we need two backslash characters in the regex.

asavonic updated this revision to Diff 425461.Apr 27 2022, 3:09 AM
thakis accepted this revision.Apr 27 2022, 4:56 AM

LG, thanks!

This revision is now accepted and ready to land.Apr 27 2022, 4:56 AM