Page MenuHomePhabricator

Disable symbol on-demand feature for Windows
ClosedPublic

Authored by yinghuitan on Apr 26 2022, 12:18 PM.

Details

Summary

Symbol on-demand feature is never tested on Windows so it is not a surprise
that we are getting Buildbot failure from Windows:
https://lab.llvm.org/buildbot/#/builders/83/builds/18228

This patch disables symbol on-demand feature on Windows. I will find a Windows
machine to test and re-enable symbol on-demand feature as follow-up.

Diff Detail

Event Timeline

yinghuitan created this revision.Apr 26 2022, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 12:18 PM
yinghuitan requested review of this revision.Apr 26 2022, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 12:18 PM
JDevlieghere accepted this revision.Apr 26 2022, 1:16 PM
This revision is now accepted and ready to land.Apr 26 2022, 1:16 PM
This revision was automatically updated to reflect the committed changes.

FWIW, I don't think that this feature, as it is implemented right now, has any chance of working on windows. Windows does not have the equivalent of .symtab (only .dynsym), so we cannot use that as a poor man's debug info substitute -- the debug info is either there -- or it isn't.

The line-table based hydration triggers could still work, I suppose.

@labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function breakpoint on exported function symbols, they might work on Windows. I can spend some time looking once I got a Windows machine. But I agree it is a lower priority based on your input.