Disable symbol on-demand feature for Windows

[yinghuitan]

Summary

Symbol on-demand feature is never tested on Windows so it is not a surprise
that we are getting Buildbot failure from Windows:
https://lab.llvm.org/buildbot/#/builders/83/builds/18228

This patch disables symbol on-demand feature on Windows. I will find a Windows
machine to test and re-enable symbol on-demand feature as follow-up.

[labath]

FWIW, I don't think that this feature, as it is implemented right now, has any chance of working on windows. Windows does not have the equivalent of .symtab (only .dynsym), so we cannot use that as a poor man's debug info substitute -- the debug info is either there -- or it isn't.

The line-table based hydration triggers could still work, I suppose.

[yinghuitan]

@labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function breakpoint on exported function symbols, they might work on Windows. I can spend some time looking once I got a Windows machine. But I agree it is a lower priority based on your input.

lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py

class TestBreakpointLanguage(TestBase):
 
     def check_location_file(self, bp, loc, test_name):
         bp_loc = bp.GetLocationAtIndex(loc)
         addr = bp_loc.GetAddress()
         comp_unit = addr.GetCompileUnit()
         comp_name = comp_unit.GetFileSpec().GetFilename()
         return comp_name == test_name
 
+    @skipIfWindows
     def test_regex_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 
         self.build()
 
         # Load symbols on-demand
         self.runCmd("settings set symbols.load-on-demand true")
 
def test_regex_breakpoint_language(self):
             "func_from",
             lldb.eLanguageTypeObjC,
             lldb.SBFileSpecList(),
             lldb.SBFileSpecList())
         self.assertEqual(
             objc_bp.GetNumLocations(), 0,
             "No ObjC symbol matches")
 
+    @skipIfWindows
     def test_by_name_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 
         self.build()
 
         # Load symbols on-demand
         self.runCmd("settings set symbols.load-on-demand true")
 

lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py

 """
 Test source text regex breakpoint hydrates module debug info
 in symbol on-demand mode.
 """
 
 
 import lldb
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TestSourceTextRegexBreakpoint(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
+    @skipIfWindows
     def test_with_run_command(self):
         self.build()
 
         # Load symbols on-demand
         self.runCmd("settings set symbols.load-on-demand true")
 
         self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
 

lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py

def common_setup(self):
         # automatically uploaded
         self.environment = self.registerSharedLibrariesWithTarget(
             self.target, self.shlib_names
         )
 
         ctx = self.platformContext
         self.shared_lib_name = ctx.shlib_prefix + "foo." + ctx.shlib_extension
 
+    @skipIfWindows
     def test_source_line_breakpoint(self):
         self.build()
         self.common_setup()
 
         lldbutil.run_break_set_by_file_and_line(
             self, "foo.c", 4, num_expected_locations=1, loc_exact=True
         )
 
def test_source_line_breakpoint(self):
         self.assertEqual(4, leaf_frame.GetLineEntry().GetLine())
 
         parent_frame = stack_frames[1]
         self.assertEqual(
             "shared.c", parent_frame.GetLineEntry().GetFileSpec().GetFilename()
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_symbolic_breakpoint(self):
         self.build()
         self.common_setup()
 
         lldbutil.run_break_set_by_symbol(
             self, "foo", sym_exact=True, num_expected_locations=1
         )
 
def test_symbolic_breakpoint(self):
         self.assertEqual(4, leaf_frame.GetLineEntry().GetLine())
 
         parent_frame = stack_frames[1]
         self.assertEqual(
             "shared.c", parent_frame.GetLineEntry().GetFileSpec().GetFilename()
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_global_variable_hydration(self):
         self.build()
         self.common_setup()
 
         lldbutil.run_break_set_by_file_and_line(
             self, self.source, self.line, num_expected_locations=1, loc_exact=True
         )
 

lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test

 # Test shows that source line breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out
 # RUN: %lldb -b -O "settings set symbols.load-on-demand true" -s %s basic.out | FileCheck %s
 
 breakpoint list
 # CHECK: No breakpoints currently set
 

lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test

 # Test shows that symbolic function breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out
 # RUN: %lldb -b -O "settings set symbols.load-on-demand true" -s %s basic.out | FileCheck %s
 
 breakpoint list
 # CHECK: No breakpoints currently set