Instead of report fatal error, this patch emit error message and exit
when shapes are not pre-defined.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
60,060 ms | x64 debian > libFuzzer.libFuzzer::large.test |
Event Timeline
llvm/test/CodeGen/X86/AMX/amx_error.ll | ||
---|---|---|
1 ↗ | (On Diff #424773) | Will update the case. |
llvm/lib/Target/X86/X86PreTileConfig.cpp | ||
---|---|---|
52 | Any benefit to use exit? I found we seldom use it in the code. | |
llvm/test/CodeGen/X86/AMX/amx-error.ll | ||
8 | Doesn't it success without this patch? https://godbolt.org/z/qvKcE3bzK |
llvm/test/CodeGen/X86/AMX/amx-error.ll | ||
---|---|---|
8 | Previously it would crash and remind user to submit a bug report. It is not good experience for user. |
llvm/lib/Target/X86/X86PreTileConfig.cpp | ||
---|---|---|
52 | Ok, let's depend on emitError to handle the error. Let me remove exit. |
llvm/lib/Target/X86/X86PreTileConfig.cpp | ||
---|---|---|
317–318 | I think we should stop compiling or at lest let it not generate out file. |
llvm/lib/Target/X86/X86PreTileConfig.cpp | ||
---|---|---|
317–318 | The error handler would indicate compiler not generate out file. If there is no error handler, compiler would exit. Pls try clang or llc. |
Any benefit to use exit? I found we seldom use it in the code.