In the case of anonymous defs this may return the name of the base def class,
which can lead to two different defs with the same name (which hits an assert).
This commit adds a new getUniqueDefName method that returns a unique name
for the constraint.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Tools/PDLL/ODS/Constraint.cpp | ||
---|---|---|
25 | Shouldn't this be drop_front? |
mlir/lib/Tools/PDLL/ODS/Constraint.cpp | ||
---|---|---|
25 | No, the names are usually in the form prettyBaseName(anonymous_...). We want to strip the anonymous stuff off of the end, so we take everything from the front up to the (. The prettyBaseName is what we want to display as the "pretty"/demangled name. |
Shouldn't this be drop_front?