Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Transforms/NewGVN/load_coercion_between_store_and_load.ll | ||
---|---|---|
3 | Should be testing -newgvn instead of gvn? |
llvm/test/Transforms/NewGVN/load_coercion_between_store_and_load.ll | ||
---|---|---|
3 | I just wanted to prove that we do the same thing as GVN. None of these tests are optimized with NewGVN. If we prefer to see the diff, then I can change it :) |
llvm/test/Transforms/NewGVN/load_coercion_between_store_and_load.ll | ||
---|---|---|
3 | I see. Then maybe use two RUN lines: ; RUN: opt -S -gvn < %s | FileCheck %s -check-prefixes=GVN,OLDGVN ; RUN: opt -S -newgvn < %s | FileCheck %s -check-prefixes=GVN,NEWGVN (as suggested offline). |
Comment Actions
LGTM.
If you prefer you could also add a common "GVN" prefix. The update_test_checks script will use this prefix when oldgvn and newgvn produce the same result, which will make it easier to see when they are different.
; RUN: opt -S -gvn < %s | FileCheck %s -check-prefixes=GVN,OLDGVN ; RUN: opt -S -newgvn < %s | FileCheck %s -check-prefixes=GVN,NEWGVN
Should be testing -newgvn instead of gvn?