[msan][libcxx] Enable -fsanitize-memory-param-retval

[ldionne]

Summary

We are considering to make -fsanitize-memory-param-retval enabled by default so probably this patch is unnneded.

[vitalybuka]

rebase

[EricWF]

Thanks. Any other sanitizers we can turn up/on?

[vitalybuka]

In D123979#3459246, @EricWF wrote:

Thanks. Any other sanitizers we can turn up/on?

From stuff which is not enabled by default -fsanitize-address-use-after-return=always can be useful
But it's also good candidate for being enabled by default in clang.

[Mordante]

I see errors in the MSAN CI build. The first failure was about 2 hours after you landed this patch.

https://buildkite.com/llvm-project/libcxx-ci/builds/10483

Could you check whether this change is the cause of the failure?

[ldionne]

[Github PR transition cleanup]

Abandoning since this needs work. Please reopen as a github PR if you still want to proceed!

libcxx/CMakeLists.txt

if (USE_SANITIZER AND NOT MSVC)
 
     if (NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" AND
             NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINFO")
       append_flags_if_supported(SANITIZER_FLAGS "-gline-tables-only")
     endif()
     if (USE_SANITIZER STREQUAL "Address")
       append_flags(SANITIZER_FLAGS "-fsanitize=address")
     elseif (USE_SANITIZER MATCHES "Memory(WithOrigins)?")
-      append_flags(SANITIZER_FLAGS -fsanitize=memory)
+      append_flags(SANITIZER_FLAGS -fsanitize=memory -fsanitize-memory-param-retval)
       if (USE_SANITIZER STREQUAL "MemoryWithOrigins")
         append_flags(SANITIZER_FLAGS "-fsanitize-memory-track-origins")
       endif()
     elseif (USE_SANITIZER STREQUAL "Undefined")
       append_flags(SANITIZER_FLAGS "-fsanitize=undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all")
     elseif (USE_SANITIZER STREQUAL "Address;Undefined" OR
             USE_SANITIZER STREQUAL "Undefined;Address")
       append_flags(SANITIZER_FLAGS "-fsanitize=address,undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all")

libcxx/utils/libcxx/test/params.py

Parameter(name='use_sanitizer', choices=['', 'Address', 'Undefined', 'Memory', 'MemoryWithOrigins', 'Thread', 'DataFlow', 'Leaks'], type=str, default='',
               AddFlag('-g -fno-omit-frame-pointer') if sanitizer else None,
 
               AddFlag('-fsanitize=undefined -fno-sanitize=float-divide-by-zero -fno-sanitize-recover=all') if sanitizer == 'Undefined' else None,
               AddFeature('ubsan')                                                                          if sanitizer == 'Undefined' else None,
 
               AddFlag('-fsanitize=address') if sanitizer == 'Address' else None,
               AddFeature('asan')            if sanitizer == 'Address' else None,
 
-              AddFlag('-fsanitize=memory')               if sanitizer in ['Memory', 'MemoryWithOrigins'] else None,
-              AddFeature('msan')                         if sanitizer in ['Memory', 'MemoryWithOrigins'] else None,
-              AddFlag('-fsanitize-memory-track-origins') if sanitizer == 'MemoryWithOrigins' else None,
+              AddFlag('-fsanitize=memory -fsanitize-memory-param-retval') if sanitizer in ['Memory', 'MemoryWithOrigins'] else None,
+              AddFeature('msan')                                          if sanitizer in ['Memory', 'MemoryWithOrigins'] else None,
+              AddFlag('-fsanitize-memory-track-origins')                  if sanitizer == 'MemoryWithOrigins' else None,
 
               AddFlag('-fsanitize=thread') if sanitizer == 'Thread' else None,
               AddFeature('tsan')           if sanitizer == 'Thread' else None,
 
               AddFlag('-fsanitize=dataflow') if sanitizer == 'DataFlow' else None,
               AddFlag('-fsanitize=leaks') if sanitizer == 'Leaks' else None,
 
               AddFeature('sanitizer-new-delete') if sanitizer in ['Address', 'Memory', 'MemoryWithOrigins', 'Thread'] else None,