Disable update_cc_test_checks.py tests in stand-alone builds

[tstellar]

Summary

The script is located in the llvm/ sub-directory, so it is not available
for when doing a stand-alone build.

See https://discourse.llvm.org/t/rfc-stand-alone-build-support/61291

[rovka]

I just have a couple of nits, I'll leave it to the clang devs to properly review this.

clang/test/CMakeLists.txt

18

Nit: These seem to be sorted alphabetically.

clang/test/utils/update_cc_test_checks/lit.local.cfg

17

[tstellar]

Address review comments.

[tstellar]

ping.

[h-vetinari]

Just comments, looks OK otherwise.

clang/test/CMakeLists.txt

6

OT for this PR, but it would be nice to eventually rename this to CLANG_BUILD_STANDALONE in accordance with the present tense used for other variables.

clang/test/lit.site.cfg.py.in

40

I'd use one spelling of standalone / stand-alone, and I think in this case it's probably the env var that wins?

clang/test/utils/update_cc_test_checks/lit.local.cfg

19

I couldn't tell from the diff where this is used (though admittedly I hardly know the LLVM infra). I also don't see it in [[ https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py | lit.cfg.py ]], the respective [[ https://github.com/llvm/llvm-project/blob/main/clang/test/CMakeLists.txt | CMakeLists.txt ]] or [[ https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/llvm/cmake/modules/AddLLVM.cmake#L1616 | configure_lit_site_cfg ]]

I trust that this does what's intended.

[tstellar]

Fix option spelling.

clang/test/utils/update_cc_test_checks/lit.local.cfg

19

The lit tool uses this to decide whether or not to run the tests in the directory.

[tstellar]

@h-vetinari Do these updates look OK to you?

[h-vetinari]

LGTM

clang/test/CMakeLists.txt

 # Test runner infrastructure for Clang. This configures the Clang test trees
 # for use by Lit, and delegates to LLVM's lit test handlers.
 
 llvm_canonicalize_cmake_booleans(
   CLANG_BUILD_EXAMPLES
+  CLANG_BUILT_STANDALONE
   CLANG_DEFAULT_PIE_ON_LINUX
   CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL
   CLANG_ENABLE_ARCMT
   CLANG_ENABLE_STATIC_ANALYZER
   CLANG_PLUGIN_SUPPORT
   CLANG_SPAWN_CC1
   ENABLE_BACKTRACES
   LLVM_ENABLE_ZLIB
   LLVM_ENABLE_PER_TARGET_RUNTIME_DIR
   LLVM_ENABLE_THREADS
   LLVM_WITH_Z3
   )
 
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
   ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py
   MAIN_CONFIG
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
   PATHS
   "LLVM_SOURCE_DIR"

clang/test/lit.site.cfg.py.in

 config.enable_backtrace = @ENABLE_BACKTRACES@
 config.enable_threads = @LLVM_ENABLE_THREADS@
 config.host_arch = "@HOST_ARCH@"
 config.python_executable = "@Python3_EXECUTABLE@"
 config.use_z3_solver = lit_config.params.get('USE_Z3_SOLVER', "@USE_Z3_SOLVER@")
 config.has_plugins = @CLANG_PLUGIN_SUPPORT@
 config.clang_vendor_uti = "@CLANG_VENDOR_UTI@"
 config.llvm_external_lit = path(r"@LLVM_EXTERNAL_LIT@")
+config.standalone_build = @CLANG_BUILT_STANDALONE@
 
 import lit.llvm
 lit.llvm.initialize(lit_config, config)
 
 # Let the main config do the real work.
 lit_config.load_config(
     config, os.path.join(config.clang_src_dir, "test/lit.cfg.py"))

clang/test/utils/update_cc_test_checks/lit.local.cfg

 import os
 import glob
 
 import lit.util
 
 # python 2.7 backwards compatibility
 try:
     from shlex import quote as shell_quote
 except ImportError:
     from pipes import quote as shell_quote
 
 
+if config.standalone_build:
+    # These tests require the update_cc_test_checks.py script from the llvm
+    # source tree, so skip these tests if we are doing standalone builds.
+    # These tests are only relevant to developers working with the
+    # update_cc_test_checks.py tool; they don't provide any coverage
+    # for any of the clang source code.
+    config.unsupported = True
+else:
+
     config.test_format = lit.formats.ShTest(execute_external=False)
     config.suffixes = ['.test']
 
     clang_path = os.path.join(config.clang_tools_dir, 'clang')
     extra_args = '--clang ' + shell_quote(clang_path)
     opt_path = os.path.join(config.llvm_tools_dir, 'opt')
     extra_args += ' --opt ' + shell_quote(opt_path)
     script_path = os.path.join(config.llvm_src_root, 'utils',
                                'update_cc_test_checks.py')
     assert os.path.isfile(script_path)
     # Windows: llvm-lit.py, Linux: llvm-lit
     if config.llvm_external_lit:
         lit = config.llvm_external_lit
     else:
         lit = shell_quote(glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0])
     python = shell_quote(config.python_executable)
     config.substitutions.append(
         ('%update_cc_test_checks', "%s %s %s" % (
             python, shell_quote(script_path), extra_args)))
     config.substitutions.append(
         ('%clang_tools_dir', shell_quote(config.clang_tools_dir)))
     config.substitutions.append(
         ('%lit', "%s %s -Dclang_lit_site_cfg=%s -j1 -vv" % (
             python, lit, shell_quote(config.clang_lit_site_cfg))))