This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Presburger] Make IntegerRelation::mergeLocalIds not delete duplicates
ClosedPublic

Authored by Groverkss on Apr 15 2022, 11:05 AM.

Details

Summary

This patch modifies mergeLocalIds to not delete duplicate local ids in
this relation. This allows the ordering of the final local ids for this
to be determined more easily, which is generally required when other objects
refer to these local ids.

Diff Detail

Event Timeline

Groverkss created this revision.Apr 15 2022, 11:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 11:05 AM
Groverkss requested review of this revision.Apr 15 2022, 11:05 AM
arjunp added inline comments.Apr 15 2022, 12:05 PM
mlir/include/mlir/Analysis/Presburger/IntegerRelation.h
477–478

Should be this and other

486
mlir/lib/Analysis/Presburger/IntegerRelation.cpp
1087–1094
1090

I can't understand this. What are local id sets?

1132–1133

"duplicates in this"*

Groverkss updated this revision to Diff 423285.Apr 17 2022, 5:30 AM
Groverkss marked 5 inline comments as done.
  • Address Arjun's comments
mlir/lib/Analysis/Presburger/IntegerRelation.cpp
1087–1094

I don't think the "both sets" is true. Local ids which are duplicated in other are also merged.

arjunp accepted this revision.Apr 17 2022, 3:21 PM

We should probably consider not this and other and also A and B in this

This revision is now accepted and ready to land.Apr 17 2022, 3:21 PM
This revision was landed with ongoing or failed builds.Apr 17 2022, 9:49 PM
This revision was automatically updated to reflect the committed changes.