Details
Details
- Reviewers
yonghong-song MaskRay - Commits
- rGc2d27c89593e: [BPF] Enable IAS in backend
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The UseIntegratedAssembler = false is added with the following commit,
commit d2e5157c1f0b1953c5166c1d656ac71e840615a4 Author: Fangrui Song <i@maskray.me> Date: Sat Apr 11 10:01:36 2020 -0700 [MC] Add UseIntegratedAssembler = false. NFC
Do you know what changed to remove UseIntegratedAssembler = false;? Does this change has any real impact on BPF backend?
Comment Actions
That commit was to offset this commit after that, since IAS was not already enabled in the backend..
commit 0a55d3f557a74cfb459b24e442072302d5444baf Author: Fangrui Song <i@maskray.me> Date: Sat Apr 11 10:06:18 2020 -0700 [MC] Default MCAsmInfo::UseIntegratedAssembler to true
Well nothing changed. As far as I can see IAS for BPF has been enabled for a long time with the Clang frontend. It should be enabled in the BPF backend as well. Almost all
other backends do as well.
Comment Actions
The BPF doesn't really recommend to compile from the assembly code to the object code, so we should be fine here. But there is a test failure test/CodeGen/BPF/inline_asm.ll. Could you take a look?