This is an archive of the discontinued LLVM Phabricator instance.

[BPF] Enable IAS in backend
ClosedPublic

Authored by brad on Apr 15 2022, 1:37 AM.

Diff Detail

Event Timeline

brad created this revision.Apr 15 2022, 1:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 1:37 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
brad requested review of this revision.Apr 15 2022, 1:37 AM

The UseIntegratedAssembler = false is added with the following commit,

commit d2e5157c1f0b1953c5166c1d656ac71e840615a4
Author: Fangrui Song <i@maskray.me>
Date:   Sat Apr 11 10:01:36 2020 -0700

    [MC] Add UseIntegratedAssembler = false. NFC

Do you know what changed to remove UseIntegratedAssembler = false;? Does this change has any real impact on BPF backend?

brad added a comment.EditedApr 21 2022, 8:28 PM

The UseIntegratedAssembler = false is added with the following commit,

commit d2e5157c1f0b1953c5166c1d656ac71e840615a4
Author: Fangrui Song <i@maskray.me>
Date:   Sat Apr 11 10:01:36 2020 -0700

    [MC] Add UseIntegratedAssembler = false. NFC

Do you know what changed to remove UseIntegratedAssembler = false;? Does this change has any real impact on BPF backend?

That commit was to offset this commit after that, since IAS was not already enabled in the backend..

commit 0a55d3f557a74cfb459b24e442072302d5444baf
Author: Fangrui Song <i@maskray.me>
Date:   Sat Apr 11 10:06:18 2020 -0700

    [MC] Default MCAsmInfo::UseIntegratedAssembler to true

Well nothing changed. As far as I can see IAS for BPF has been enabled for a long time with the Clang frontend. It should be enabled in the BPF backend as well. Almost all
other backends do as well.

The BPF doesn't really recommend to compile from the assembly code to the object code, so we should be fine here. But there is a test failure test/CodeGen/BPF/inline_asm.ll. Could you take a look?

brad updated this revision to Diff 434364.Jun 5 2022, 6:46 PM

Fix test.

brad added a reviewer: MaskRay.Jun 5 2022, 7:46 PM
MaskRay accepted this revision.Jun 5 2022, 8:26 PM
This revision is now accepted and ready to land.Jun 5 2022, 8:26 PM
This revision was automatically updated to reflect the committed changes.