Page MenuHomePhabricator

[CompilerRT] Fix 128-bit floating point division
Needs ReviewPublic

Authored by kpdev42 on Apr 14 2022, 1:41 AM.

Details

Summary

Patch fixes number of iterations which should be 5 for given reciprocal precision, not 4.

OS Laboratory. Huawei Russian Research Institute. Saint-Petersburg

Diff Detail

Unit TestsFailed

TimeTest
1,730 msx64 debian > Clang.utils/update_cc_test_checks::check-globals.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp
760 msx64 debian > Clang.utils/update_cc_test_checks::global-hex-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp
740 msx64 debian > Clang.utils/update_cc_test_checks::global-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp
2,920 msx64 debian > SanitizerCommon-asan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
1,120 msx64 debian > SanitizerCommon-asan-x86_64-Linux.Posix::sem_open.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -m64 -funwind-tables -ldl -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/sem_open.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Posix/Output/sem_open.cpp.tmp && /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Posix/Output/sem_open.cpp.tmp
View Full Test Results (51 Failed)

Event Timeline

kpdev42 created this revision.Apr 14 2022, 1:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 1:41 AM
kpdev42 requested review of this revision.Apr 14 2022, 1:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 1:41 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Can you give some context here? How did we end up with "4" in the first place, and how do you know "5" is sufficient for all 128-bit floats?