This is an archive of the discontinued LLVM Phabricator instance.

[llvm/utils] Enable fpcmp
Needs ReviewPublic

Authored by taewookoh on Apr 12 2022, 2:39 PM.

Details

Summary

fpcmp is useful for comparing floating point values within noise margin, but currently not built. This diff enables fpcmp.

Diff Detail

Event Timeline

taewookoh created this revision.Apr 12 2022, 2:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 2:39 PM
Herald added a subscriber: mgorny. · View Herald Transcript
taewookoh requested review of this revision.Apr 12 2022, 2:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 2:39 PM
taewookoh retitled this revision from [llvm/utils] Enable fpcmp. to [llvm/utils] Enable fpcmp.Apr 12 2022, 2:43 PM
taewookoh edited the summary of this revision. (Show Details)

I don't think that fpcmp by itself will help, we need to integrate this with filecheck. We aren't using one-or-the-other right? We need CHECK: labels with magic regex's.

That would be great but I think fpcmp can be used as is by providing reference input file to it (and not using FileCheck). Does this make sense to you?

I don't think it will be super helpful for our use-cases, because we don't want to have a full reference output we diff against, we want CHECK: style tests.

I didn't realize that fpcmp wasn't built when I mentioned it. If this is the case, maybe we should just delete it from the LLVM tree as dead code :)