fpcmp is useful for comparing floating point values within noise margin, but currently not built. This diff enables fpcmp.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I don't think that fpcmp by itself will help, we need to integrate this with filecheck. We aren't using one-or-the-other right? We need CHECK: labels with magic regex's.
Comment Actions
That would be great but I think fpcmp can be used as is by providing reference input file to it (and not using FileCheck). Does this make sense to you?
Comment Actions
I don't think it will be super helpful for our use-cases, because we don't want to have a full reference output we diff against, we want CHECK: style tests.
I didn't realize that fpcmp wasn't built when I mentioned it. If this is the case, maybe we should just delete it from the LLVM tree as dead code :)