Details
Details
Diff Detail
Diff Detail
Event Timeline
llvm/lib/Target/Mips/MipsISelLowering.cpp | ||
---|---|---|
1178 | Add a comment here: // For MIPSR2 or later, we may be able to use the `ext` instruction or its' double-word variants. | |
1179 | I believe this code would be clearer if it was the likes of: if (auto *C = dyn_Cast<ConstantSDNode>(Y)) return C->getAPIntValue().ule(14); return false; Also, the 14 should be 15 here. andi takes a 16-bit immediate. |
llvm/lib/Target/Mips/MipsISelLowering.cpp | ||
---|---|---|
1179 | This number represents the shift, As shown below |
llvm/lib/Target/Mips/MipsISelLowering.cpp | ||
---|---|---|
1179 | Sorry, the immediate range of the and instruction of Mips is uimm6 instead of sim16. I have fixed and corrected the test case |
Add a comment here: