This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata
ClosedPublic

Authored by saiislam on Apr 11 2022, 11:07 AM.

Details

Summary

Code object version 5 adds support of hidden_heap_v1 kernarg
metadata field [1]. It is a global address space pointer to an
initialized memory buffer that conforms to the requirements of the
malloc/free device library V1 version implementation.

[1] https://llvm.org/docs/AMDGPUUsage.html#amdgpu-amdhsa-code-object-kernel-argument-metadata-map-table-v5

Diff Detail

Event Timeline

saiislam created this revision.Apr 11 2022, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2022, 11:07 AM
Herald added subscribers: kerbowa, t-tye, tpr and 4 others. · View Herald Transcript
saiislam requested review of this revision.Apr 11 2022, 11:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2022, 11:07 AM
carlo.bertolli accepted this revision.Apr 12 2022, 11:15 AM

LGTM, thanks for this.

This revision is now accepted and ready to land.Apr 12 2022, 11:15 AM
This revision was landed with ongoing or failed builds.Apr 12 2022, 8:58 PM
This revision was automatically updated to reflect the committed changes.