This is an archive of the discontinued LLVM Phabricator instance.

File Extension
Needs ReviewPublic

Authored by ps-19 on Apr 8 2022, 10:14 AM.

Details

Summary

Transferred the file from .txt to .md file as .md is now more standard than .txt .

Name: Priyansh Singh
Email: priyansh.singh100@gmail.com

Diff Detail

Event Timeline

ps-19 created this revision.Apr 8 2022, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 10:14 AM
ps-19 requested review of this revision.Apr 8 2022, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 10:14 AM
ps-19 edited the summary of this revision. (Show Details)Apr 8 2022, 10:15 AM
beanz added a comment.Apr 25 2022, 1:25 PM

Overall this seems like a nice change. There is one unrelated change fixing a typo in here that should be removed and posted separately.

llvm/utils/wciia.py
101

This change is unrelated, and should be in a separate patch.

ldionne resigned from this revision.Apr 25 2022, 2:37 PM
smeenai resigned from this revision.Apr 28 2022, 1:30 PM

I'm not really sure about the ".md being more standard than .txt" in the summary, but I guess it's more standard with Github (where Markdown gets nice rendering), so this makes sense.