Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"
ClosedPublic
Actions

Authored by bnbarham on Apr 4 2022, 5:19 PM.

Details

Reviewers

dexonsmith

Commits

rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

Summary

This reverts commit 3fda0edc51fd68192a30e302d45db081bb02d7f9.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,030 ms	x64 debian > libFuzzer.libFuzzer::large.test Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LargeTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/large.test.tmp-LargeTest

Event Timeline

bnbarham created this revision.Apr 4 2022, 5:19 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 5:19 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

bnbarham requested review of this revision.Apr 4 2022, 5:19 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 4 2022, 5:19 PM

Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript

This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding ExposesExternalVFSPath instead of replacing IsVFSMapped.

Harbormaster completed remote builds in B157869: Diff 420354.Apr 4 2022, 6:32 PM

In D123103#3428298, @bnbarham wrote:

This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding ExposesExternalVFSPath instead of replacing IsVFSMapped.

Please expand the commit message to include some details (such as these) so git-log is more useful. With that, LGTM.

This revision is now accepted and ready to land.Apr 4 2022, 6:34 PM

dexonsmith mentioned this in D123104: [Modules] Use looked-up filename when looking for module maps.Apr 4 2022, 7:18 PM

This revision was landed with ongoing or failed builds.Apr 5 2022, 2:25 PM

Closed by commit rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped" (authored by bnbarham). · Explain Why

This revision was automatically updated to reflect the committed changes.

bnbarham added a commit: rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".