Page MenuHomePhabricator

Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"
ClosedPublic

Authored by bnbarham on Apr 4 2022, 5:19 PM.

Diff Detail

Event Timeline

bnbarham created this revision.Apr 4 2022, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 5:19 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
bnbarham requested review of this revision.Apr 4 2022, 5:19 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 4 2022, 5:19 PM

This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding ExposesExternalVFSPath instead of replacing IsVFSMapped.

dexonsmith accepted this revision.Apr 4 2022, 6:34 PM

This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding ExposesExternalVFSPath instead of replacing IsVFSMapped.

Please expand the commit message to include some details (such as these) so git-log is more useful. With that, LGTM.

This revision is now accepted and ready to land.Apr 4 2022, 6:34 PM
This revision was landed with ongoing or failed builds.Apr 5 2022, 2:25 PM
This revision was automatically updated to reflect the committed changes.