This is an archive of the discontinued LLVM Phabricator instance.

Differential D123081

[libc++] Add back-deployment testing on arm64 macs
ClosedPublic

Authored by ldionne on Apr 4 2022, 2:54 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Commits
rGb7042b73a399: [libc++] Add back-deployment testing on arm64 macs

Diff Detail

Event Timeline

ldionne created this revision.Apr 4 2022, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 2:54 PM
Herald added subscribers: kristof.beyls, arichardson. · View Herald Transcript
ldionne requested review of this revision.Apr 4 2022, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 2:54 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne added a comment.Apr 4 2022, 2:54 PM

I don't expect this to work the first time around.

ldionne mentioned this in D122598: [libcxx] avoid using anonymous struct with base classes (fixes gcc-12).Apr 4 2022, 2:56 PM
ldionne added a child revision: D122598: [libcxx] avoid using anonymous struct with base classes (fixes gcc-12).
Harbormaster completed remote builds in B157834: Diff 420317.Apr 4 2022, 7:08 PM
ldionne updated this revision to Diff 420366.Apr 4 2022, 7:15 PM

Fix typo in job definition. Also, remove all other jobs just for testing purposes.

Herald added a subscriber: mstorsjo. · View Herald TranscriptApr 4 2022, 7:15 PM
Harbormaster completed remote builds in B157878: Diff 420366.Apr 4 2022, 7:27 PM
azat added a subscriber: azat.Apr 4 2022, 11:50 PM
ldionne updated this revision to Diff 420475.Apr 5 2022, 5:56 AM

Adjust XFAIL markup.

Herald added subscribers: jdoerfert, arphaman. · View Herald TranscriptApr 5 2022, 5:56 AM
Harbormaster completed remote builds in B157956: Diff 420475.Apr 5 2022, 6:08 AM
ldionne updated this revision to Diff 420505.Apr 5 2022, 7:33 AM

Fix some tests.

Harbormaster completed remote builds in B157980: Diff 420505.Apr 5 2022, 7:45 AM
ldionne updated this revision to Diff 420606.Apr 5 2022, 12:35 PM

Try to adjust remaining CI failures

Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 12:35 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B158048: Diff 420606.Apr 5 2022, 12:48 PM
ldionne updated this revision to Diff 421039.Apr 6 2022, 4:09 PM

Rebase onto main after updating CI nodes to macOS 12.

Harbormaster completed remote builds in B158358: Diff 421039.Apr 6 2022, 4:23 PM
ldionne updated this revision to Diff 421042.Apr 6 2022, 4:32 PM

Add missing XFAILs

Harbormaster completed remote builds in B158362: Diff 421042.Apr 6 2022, 6:04 PM
ldionne accepted this revision.Apr 7 2022, 7:15 AM
This revision is now accepted and ready to land.Apr 7 2022, 7:15 AM
Closed by commit rGb7042b73a399: [libc++] Add back-deployment testing on arm64 macs (authored by ldionne). · Explain WhyApr 7 2022, 7:15 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGb7042b73a399: [libc++] Add back-deployment testing on arm64 macs.

Revision Contents

PathSize
libcxx/
utils/
ci/
15 lines

Diff 420317

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 678 Lines • ▼ Show 20 Lines - label: "Apple back-deployment macosx10.15"
os: "macos" os: "macos"
arch: "x86_64" # We need to use x86_64 for back-deployment CI, since the old dylibs were compiled for x86_64 arch: "x86_64" # We need to use x86_64 for back-deployment CI, since the old dylibs were compiled for x86_64
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "Apple back-deployment macosx11.0 arm64"
command: "libcxx/utils/ci/run-buildbot apple-system-backdeployment-11.0"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
agents:
queue: "libcxx-builders"
os: "macos"
arch: "am64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
- group: "ARM" - group: "ARM"
steps: steps:
- label: "AArch64" - label: "AArch64"
command: "libcxx/utils/ci/run-buildbot aarch64" command: "libcxx/utils/ci/run-buildbot aarch64"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
agents: agents:
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines