This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Vector] Add constant folder for insertelement.
ClosedPublic

Authored by jacquesguan on Mar 30 2022, 4:17 AM.

Details

Summary

This revision adds constant folder for vector.insertelement.

Diff Detail

Event Timeline

jacquesguan created this revision.Mar 30 2022, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 4:17 AM
jacquesguan requested review of this revision.Mar 30 2022, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 4:17 AM

please include file context on the reviews (meaning use -U9999999 when creating the patch): https://llvm.org/docs/Phabricator.html#id8)

mlir/lib/Dialect/Vector/IR/VectorOps.cpp
1843

nit: breakup this line to match the style of the file/project.

ThomasRaoux accepted this revision.Mar 31 2022, 8:40 AM
This revision is now accepted and ready to land.Mar 31 2022, 8:40 AM

Rebase and address comment.

please include file context on the reviews (meaning use -U9999999 when creating the patch): https://llvm.org/docs/Phabricator.html#id8)

I am using the Arcanist to upload the revision, does this miss something? I will recheck the configuration. Thanks.

mlir/lib/Dialect/Vector/IR/VectorOps.cpp
1843

Done, thanks.

This revision was automatically updated to reflect the committed changes.