This is an archive of the discontinued LLVM Phabricator instance.

Differential D122712

Make test case warning more specific for pattern match
Needs ReviewPublic

Authored by rs on Mar 30 2022, 2:29 AM.

Details

Reviewers
simpal01
keith.walker.arm
benshi001
lenary
Summary

It's possible that other compilers based on llvm might produce other warnings. So I think it would be good if this warning was a bit more specific.

Diff Detail

Event Timeline

rs created this revision.Mar 30 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 2:29 AM
Herald added subscribers: Jim, dylanmckay. · View Herald Transcript
rs requested review of this revision.Mar 30 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 2:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rs added reviewers: simpal01, lenary, keith.walker.arm.Mar 30 2022, 3:13 AM
benshi001 added a comment.Mar 30 2022, 3:57 AM

I do not like this change, since

  1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line // NOWARN-NOT: warning: means non of these possible warnings will be emitted.
  1. we may add/delete/modify warnings in the future, so we should not make it specific .
rs added a comment.Mar 30 2022, 6:04 AM
In D122712#3416238, @benshi001 wrote:

I do not like this change, since

  1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line // NOWARN-NOT: warning: means non of these possible warnings will be emitted.
  1. we may add/delete/modify warnings in the future, so we should not make it specific .

ok fair enough.

Harbormaster completed remote builds in B156906: Diff 419080.Mar 30 2022, 2:57 PM
benshi001 requested changes to this revision.Mar 31 2022, 6:27 PM
This revision now requires changes to proceed.Mar 31 2022, 6:27 PM
benshi001 resigned from this revision.Apr 6 2022, 7:03 AM
This revision now requires review to proceed.Apr 6 2022, 7:03 AM
lenary resigned from this revision.Sep 28 2022, 5:38 AM

Revision Contents

PathSize
clang/
test/
Driver/
2 lines

Diff 419080

clang/test/Driver/avr-toolchain.c

Show All 33 Lines
// RUN: %clang %s -### --target=avr --sysroot=%S/Inputs/basic_avr_tree 2>&1 -nostdinc | FileCheck --check-prefix=NOSTDINC %s // RUN: %clang %s -### --target=avr --sysroot=%S/Inputs/basic_avr_tree 2>&1 -nostdinc | FileCheck --check-prefix=NOSTDINC %s
// RUN: %clang %s -### --target=avr --sysroot=%S/Inputs/basic_avr_tree 2>&1 -nostdlibinc | FileCheck --check-prefix=NOSTDINC %s // RUN: %clang %s -### --target=avr --sysroot=%S/Inputs/basic_avr_tree 2>&1 -nostdlibinc | FileCheck --check-prefix=NOSTDINC %s
// NOSTDINC-NOT: "-internal-isystem" {{".*avr/include"}} // NOSTDINC-NOT: "-internal-isystem" {{".*avr/include"}}
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -mmcu=atmega328 %s 2>&1 | FileCheck --check-prefix=NOWARN %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -mmcu=atmega328 %s 2>&1 | FileCheck --check-prefix=NOWARN %s
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -mmcu=atmega328 -S %s 2>&1 | FileCheck --check-prefix=NOWARN %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -mmcu=atmega328 -S %s 2>&1 | FileCheck --check-prefix=NOWARN %s
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/ -mmcu=atmega328 -S %s 2>&1 | FileCheck --check-prefix=NOWARN %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/ -mmcu=atmega328 -S %s 2>&1 | FileCheck --check-prefix=NOWARN %s
// NOWARN-NOT: warning: // NOWARN-NOT: warning: no target microcontroller specified on command line, cannot link standard libraries
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -S %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKA %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree -S %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKA %s
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/ -S %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKA %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/ -S %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKA %s
// RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKB %s // RUN: %clang -### --target=avr --sysroot=%S/Inputs/basic_avr_tree %s 2>&1 | FileCheck --check-prefixes=NOMCU,LINKB %s
// NOMCU: warning: no target microcontroller specified on command line, cannot link standard libraries, please pass -mmcu=<mcu name> // NOMCU: warning: no target microcontroller specified on command line, cannot link standard libraries, please pass -mmcu=<mcu name>
// LINKB: warning: standard library not linked and so no interrupt vector table or compiler runtime routines will be linked // LINKB: warning: standard library not linked and so no interrupt vector table or compiler runtime routines will be linked
// LINKB: warning: support for passing the data section address to the linker for microcontroller '' is not implemented // LINKB: warning: support for passing the data section address to the linker for microcontroller '' is not implemented
// NOMCU-NOT: warning: {{.*}} avr-gcc // NOMCU-NOT: warning: {{.*}} avr-gcc
Show All 10 Lines