Page MenuHomePhabricator

Make test case warning more specific for pattern match
Needs ReviewPublic

Authored by rs on Mar 30 2022, 2:29 AM.

Details

Summary

It's possible that other compilers based on llvm might produce other warnings. So I think it would be good if this warning was a bit more specific.

Diff Detail

Event Timeline

rs created this revision.Mar 30 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 2:29 AM
rs requested review of this revision.Mar 30 2022, 2:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 2:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I do not like this change, since

  1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line // NOWARN-NOT: warning: means non of these possible warnings will be emitted.
  1. we may add/delete/modify warnings in the future, so we should not make it specific .
rs added a comment.Mar 30 2022, 6:04 AM

I do not like this change, since

  1. actually there may be many kinds of warnings emitted by the clang-driver-avr depending on different options, and this single line // NOWARN-NOT: warning: means non of these possible warnings will be emitted.
  1. we may add/delete/modify warnings in the future, so we should not make it specific .

ok fair enough.

benshi001 requested changes to this revision.Mar 31 2022, 6:27 PM
This revision now requires changes to proceed.Mar 31 2022, 6:27 PM
benshi001 resigned from this revision.Apr 6 2022, 7:03 AM
This revision now requires review to proceed.Apr 6 2022, 7:03 AM
lenary resigned from this revision.Sep 28 2022, 5:38 AM