This is an archive of the discontinued LLVM Phabricator instance.

Differential D122700

Do not generate x86_64 test targets on AS hots
ClosedPublic

Authored by yln on Mar 29 2022, 7:16 PM.

Details

Reviewers
arphaman
steven_wu
delcypher
aralisza
kubamracek
Commits
rG15c4239dff0f: Do not generate x86_64 test targets on AS hosts

Diff Detail

Event Timeline

yln created this revision.Mar 29 2022, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 7:16 PM
Herald added a subscriber: mgorny. · View Herald Transcript
yln requested review of this revision.Mar 29 2022, 7:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 7:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln added a comment.Mar 29 2022, 7:18 PM

Relevant: https://reviews.llvm.org/D82610

yln retitled this revision from Do not generate x86_64 test targets on M1 Macs to Do not generate x86_64 test targets on AS hots.Mar 29 2022, 7:20 PM
kubamracek accepted this revision.Mar 30 2022, 11:13 AM
This revision is now accepted and ready to land.Mar 30 2022, 11:13 AM
steven_wu accepted this revision.Mar 30 2022, 11:19 AM
This revision was landed with ongoing or failed builds.Mar 30 2022, 11:32 AM
Closed by commit rG15c4239dff0f: Do not generate x86_64 test targets on AS hosts (authored by yln). · Explain Why
This revision was automatically updated to reflect the committed changes.
yln added a commit: rG15c4239dff0f: Do not generate x86_64 test targets on AS hosts.
Harbormaster completed remote builds in B156877: Diff 419037.Mar 30 2022, 1:08 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 419037

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines if(CPUTYPE_MATCHED)
# ARM cputype is (0x01000000 | 12) and X86(_64) is always 7. # ARM cputype is (0x01000000 | 12) and X86(_64) is always 7.
if(${CMAKE_MATCH_1} GREATER 11) if(${CMAKE_MATCH_1} GREATER 11)
set(ARM_HOST On) set(ARM_HOST On)
endif() endif()
endif() endif()
if(ARM_HOST) if(ARM_HOST)
list(REMOVE_ITEM tmp_var i386) list(REMOVE_ITEM tmp_var i386)
list(REMOVE_ITEM tmp_var x86_64)
list(REMOVE_ITEM tmp_var x86_64h)
else() else()
list(REMOVE_ITEM tmp_var arm64) list(REMOVE_ITEM tmp_var arm64)
list(REMOVE_ITEM tmp_var arm64e) list(REMOVE_ITEM tmp_var arm64e)
execute_process( execute_process(
COMMAND sysctl hw.cpusubtype COMMAND sysctl hw.cpusubtype
OUTPUT_VARIABLE SUBTYPE) OUTPUT_VARIABLE SUBTYPE)
string(REGEX MATCH "hw.cpusubtype: ([0-9]*)" string(REGEX MATCH "hw.cpusubtype: ([0-9]*)"
SUBTYPE_MATCHED "${SUBTYPE}") SUBTYPE_MATCHED "${SUBTYPE}")
▲ Show 20 Lines • Show All 395 Lines • Show Last 20 Lines