Page MenuHomePhabricator

[compiler-rt] Add support for arm64 macOS
ClosedPublic

Authored by steven_wu on Jun 25 2020, 4:35 PM.

Diff Detail

Event Timeline

steven_wu created this revision.Jun 25 2020, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2020, 4:35 PM
Herald added subscribers: Restricted Project, danielkiss, ributzka and 4 others. · View Herald Transcript
arphaman accepted this revision.Jun 25 2020, 4:41 PM
This revision is now accepted and ready to land.Jun 25 2020, 4:41 PM
dexonsmith accepted this revision.Jun 25 2020, 4:43 PM

LGTM, after you fix the nits I mention inline.

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp
175

You missed updating this #endif comment to match the new #if condition.

202

You missed updating this #endif comment to match the new #if condition.

This revision was automatically updated to reflect the committed changes.