This is an archive of the discontinued LLVM Phabricator instance.

Differential D122480

[Flang] Lower achar intrinsic
ClosedPublic

Authored by kiranchandramohan on Mar 25 2022, 6:51 AM.

Details

Reviewers
clementval
schweitz
PeteSteinfeld
sscalpone
Commits
rG7babc8e6cdd8: [Flang] Lower achar intrinsic
Summary

The intrinsic returns the character located at the position requested
in the ASCII sequence. The intrinsic is lowered to inline FIR code.

This is part of the upstreaming effort from the fir-dev branch in [1].
[1] https://github.com/flang-compiler/f18-llvm-project

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

kiranchandramohan created this revision.Mar 25 2022, 6:51 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptMar 25 2022, 6:51 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: mehdi_amini. · View Herald Transcript
kiranchandramohan requested review of this revision.Mar 25 2022, 6:51 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 25 2022, 6:51 AM
clementval accepted this revision.Mar 25 2022, 6:54 AM

LGTM

This revision is now accepted and ready to land.Mar 25 2022, 6:54 AM
This revision was landed with ongoing or failed builds.Mar 25 2022, 7:25 AM
Closed by commit rG7babc8e6cdd8: [Flang] Lower achar intrinsic (authored by kiranchandramohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
kiranchandramohan added a commit: rG7babc8e6cdd8: [Flang] Lower achar intrinsic.
Harbormaster completed remote builds in B156279: Diff 418212.Mar 25 2022, 7:32 AM

Revision Contents

PathSize
flang/
lib/
Lower/
1 line
test/
Lower/
Intrinsics/
23 lines

Diff 418217

flang/lib/Lower/IntrinsicCall.cpp

Show First 20 Lines • Show All 642 Lines • ▼ Show 20 Lines
/// one to one mapping with Fortran arguments. If no mapping is /// one to one mapping with Fortran arguments. If no mapping is
/// defined here for a generic intrinsic, genRuntimeCall will be called /// defined here for a generic intrinsic, genRuntimeCall will be called
/// to look for a match in the runtime a emit a call. Note that the argument /// to look for a match in the runtime a emit a call. Note that the argument
/// lowering rules for an intrinsic need to be provided only if at least one /// lowering rules for an intrinsic need to be provided only if at least one
/// argument must not be lowered by value. In which case, the lowering rules /// argument must not be lowered by value. In which case, the lowering rules
/// should be provided for all the intrinsic arguments for completeness. /// should be provided for all the intrinsic arguments for completeness.
static constexpr IntrinsicHandler handlers[]{ static constexpr IntrinsicHandler handlers[]{
{"abs", &I::genAbs}, {"abs", &I::genAbs},
{"achar", &I::genChar},
{"adjustl", {"adjustl",
&I::genAdjustRtCall<fir::runtime::genAdjustL>, &I::genAdjustRtCall<fir::runtime::genAdjustL>,
{{{"string", asAddr}}}, {{{"string", asAddr}}},
/*isElemental=*/true}, /*isElemental=*/true},
{"adjustr", {"adjustr",
&I::genAdjustRtCall<fir::runtime::genAdjustR>, &I::genAdjustRtCall<fir::runtime::genAdjustR>,
{{{"string", asAddr}}}, {{{"string", asAddr}}},
/*isElemental=*/true}, /*isElemental=*/true},
▲ Show 20 Lines • Show All 3,120 Lines • Show Last 20 Lines

flang/test/Lower/Intrinsics/achar.f90

  • This file was added.
! RUN: bbc -emit-fir %s -o - | fir-opt --canonicalize | FileCheck %s
! RUN: %flang_fc1 -emit-fir %s -o - | fir-opt --canonicalize | FileCheck %s
! CHECK-LABEL: test1
! CHECK-SAME: (%[[XREF:.*]]: !fir.ref<i32> {{.*}}, %[[CBOX:.*]]: !fir.boxchar<1> {{.*}})
! CHECK: %[[C1:.*]] = arith.constant 1 : index
! CHECK: %[[FALSE:.*]] = arith.constant false
! CHECK: %[[TEMP:.*]] = fir.alloca !fir.char<1> {adapt.valuebyref}
! CHECK: %[[C:.*]]:2 = fir.unboxchar %[[CBOX]] : (!fir.boxchar<1>) -> (!fir.ref<!fir.char<1,?>>, index)
! CHECK: %[[X:.*]] = fir.load %[[XREF]] : !fir.ref<i32>
! CHECK: %[[X_I8:.*]] = fir.convert %[[X]] : (i32) -> i8
! CHECK: %[[UNDEF:.*]] = fir.undefined !fir.char<1>
! CHECK: %[[XCHAR:.*]] = fir.insert_value %[[UNDEF]], %[[X_I8]], [0 : index] : (!fir.char<1>, i8) -> !fir.char<1>
! CHECK: fir.store %[[XCHAR]] to %[[TEMP]] : !fir.ref<!fir.char<1>>
! CHECK: %[[C1_I64:.*]] = fir.convert %[[C1]] : (index) -> i64
! CHECK: %[[C_CVT:.*]] = fir.convert %[[C]]#0 : (!fir.ref<!fir.char<1,?>>) -> !fir.ref<i8>
! CHECK: %[[TEMP_WITH_XCHAR:.*]] = fir.convert %[[TEMP]] : (!fir.ref<!fir.char<1>>) -> !fir.ref<i8>
! CHECK: fir.call @llvm.memmove.p0i8.p0i8.i64(%[[C_CVT]], %[[TEMP_WITH_XCHAR]], %[[C1_I64]], %[[FALSE]]) : (!fir.ref<i8>, !fir.ref<i8>, i64, i1) -> ()
subroutine test1(x, c)
integer :: x
character :: c
c = achar(x)
end subroutine