This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][Atomics] Fix lowering of llvm.ppc.cfence on i128 when `-ppc-quadword-atomics` is off
AbandonedPublic

Authored by lkail on Mar 25 2022, 3:38 AM.

Details

Reviewers
jsji
Group Reviewers
Restricted Project
Summary

The failure happens when frontend doesn't emit libcall for 16byte atomic load/store, and AtomicExpandPass emits llvm.ppc.cfence for ordering.

Diff Detail

Event Timeline

lkail created this revision.Mar 25 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 3:38 AM
lkail requested review of this revision.Mar 25 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 3:38 AM
lkail retitled this revision from [PowerPC][Atomics] Fix lowering of llvm.ppc.cfence on i128 if `-ppc-quadword-atomics` is not specified to [PowerPC][Atomics] Fix lowering of llvm.ppc.cfence on i128 when `-ppc-quadword-atomics` is off.Mar 25 2022, 3:41 AM
lkail abandoned this revision.Apr 9 2022, 1:37 AM

The issue is fixed by https://reviews.llvm.org/D122868. We don't need to lower cfence when emitting __atomic* libcalls.