This is an archive of the discontinued LLVM Phabricator instance.

Differential D122447

Prevent comparison with wider type in loop condition
ClosedPublic

Authored by aakanksha555 on Mar 24 2022, 6:36 PM.

Details

Reviewers
kzhuravl
rampitec
msearles
arsenm
tpr
Commits
rGb0225ab8fd4f: Prevent comparison with wider type in loop condition
Summary

This change fixes the code violations flagged in AMD compute CodeQL scan - "comparison-with-wider-type"

Diff Detail

Unit TestsFailed

TimeTest
60,070 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::large.test

Event Timeline

aakanksha555 created this revision.Mar 24 2022, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 6:36 PM
aakanksha555 requested review of this revision.Mar 24 2022, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 6:36 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aakanksha555 added a reviewer: arsenm.Mar 24 2022, 6:42 PM
Herald added a subscriber: wdng. · View Herald TranscriptMar 24 2022, 6:42 PM
Harbormaster completed remote builds in B156191: Diff 418102.Mar 24 2022, 7:43 PM
aakanksha555 added a reviewer: tpr.Mar 25 2022, 1:37 AM
aakanksha555 updated this revision to Diff 418156.Mar 25 2022, 1:53 AM
Harbormaster completed remote builds in B156235: Diff 418156.Mar 25 2022, 2:42 AM
tpr accepted this revision.Mar 25 2022, 2:45 AM

LGTM if clang-format thing is fixed.

This revision is now accepted and ready to land.Mar 25 2022, 2:45 AM
aakanksha555 updated this revision to Diff 418173.Mar 25 2022, 3:32 AM
Harbormaster completed remote builds in B156248: Diff 418173.Mar 25 2022, 4:14 AM
Closed by commit rGb0225ab8fd4f: Prevent comparison with wider type in loop condition (authored by Aakanksha <paakan@amd.com>). · Explain WhyMar 25 2022, 4:35 AM
This revision was automatically updated to reflect the committed changes.
Aakanksha <paakan@amd.com> added a commit: rGb0225ab8fd4f: Prevent comparison with wider type in loop condition.

Revision Contents

PathSize
llvm/
utils/
TableGen/
2 lines

Diff 418102

llvm/utils/TableGen/X86RecognizableInstr.cpp

Show First 20 Lines • Show All 834 Lines • ▼ Show 20 Lines#define MAP(from, to) \
if (Form == X86Local::AddRegFrm || Form == X86Local::MRMSrcRegCC || if (Form == X86Local::AddRegFrm || Form == X86Local::MRMSrcRegCC ||
Form == X86Local::MRMSrcMemCC || Form == X86Local::MRMXrCC || Form == X86Local::MRMSrcMemCC || Form == X86Local::MRMXrCC ||
Form == X86Local::MRMXmCC || Form == X86Local::AddCCFrm) { Form == X86Local::MRMXmCC || Form == X86Local::AddCCFrm) {
uint8_t Count = Form == X86Local::AddRegFrm ? 8 : 16; uint8_t Count = Form == X86Local::AddRegFrm ? 8 : 16;
assert(((opcodeToSet % Count) == 0) && "ADDREG_FRM opcode not aligned"); assert(((opcodeToSet % Count) == 0) && "ADDREG_FRM opcode not aligned");
uint8_t currentOpcode; uint8_t currentOpcode;
for (currentOpcode = opcodeToSet; currentOpcode < opcodeToSet + Count; for (currentOpcode = opcodeToSet; currentOpcode < (uint8_t)(opcodeToSet + Count);
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    for (currentOpcode = opcodeToSet; currentOpcode < (uint8_t)(opcodeToSet + Count);
-         ++currentOpcode)
+    for (currentOpcode = opcodeToSet;
+         currentOpcode < (uint8_t)(opcodeToSet + Count); ++currentOpcode)
Lint: Pre-merge checks: clang-format: please reformat the code ``` - for (currentOpcode = opcodeToSet; currentOpcode…
++currentOpcode) ++currentOpcode)
tables.setTableFields(*opcodeType, insnContext(), currentOpcode, *filter, tables.setTableFields(*opcodeType, insnContext(), currentOpcode, *filter,
UID, Is32Bit, OpPrefix == 0, UID, Is32Bit, OpPrefix == 0,
IgnoresVEX_L || EncodeRC, IgnoresVEX_L || EncodeRC,
IgnoresVEX_W, AddressSize); IgnoresVEX_W, AddressSize);
} else { } else {
tables.setTableFields(*opcodeType, insnContext(), opcodeToSet, *filter, UID, tables.setTableFields(*opcodeType, insnContext(), opcodeToSet, *filter, UID,
Is32Bit, OpPrefix == 0, IgnoresVEX_L || EncodeRC, Is32Bit, OpPrefix == 0, IgnoresVEX_L || EncodeRC,
▲ Show 20 Lines • Show All 418 Lines • Show Last 20 Lines