This is an archive of the discontinued LLVM Phabricator instance.

Differential D122365

[LoongArch] Add LoongArch support to update_llc_test_checks
AbandonedPublic

Authored by wangleiat on Mar 23 2022, 6:19 PM.

Details

Reviewers
spatel
MaskRay
rengolin
xen0n
Summary

Add LoongArch assembly scrubbing and triple support to update_llc_test_checks.

Diff Detail

Event Timeline

wangleiat created this revision.Mar 23 2022, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 6:19 PM
Herald added subscribers: StephenFan, arichardson. · View Herald Transcript
wangleiat requested review of this revision.Mar 23 2022, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 6:19 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
wangleiat updated this revision to Diff 417802.Mar 23 2022, 6:26 PM

Remove unused 'Change-ID'

Harbormaster completed remote builds in B155980: Diff 417802.Mar 23 2022, 7:13 PM
MaskRay added a comment.Mar 23 2022, 10:21 PM

This needs tests in llvm/test/tools/UpdateTestChecks/update_llc_test_checks/

wangleiat abandoned this revision.Mar 24 2022, 12:12 AM
In D122365#3404557, @MaskRay wrote:

This needs tests in llvm/test/tools/UpdateTestChecks/update_llc_test_checks/

Because the codegen of the current loongarch backend has not been completed, unable to add test cases completely, so abenden it first.
Thank you.

Revision Contents

PathSize
llvm/
utils/
UpdateTestChecks/
19 lines

Diff 417802

llvm/utils/UpdateTestChecks/asm.py

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 LinesASM_FUNCTION_VE_RE = re.compile(
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_CSKY_RE = re.compile( ASM_FUNCTION_CSKY_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?' r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?'
r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*' r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
r'.Lfunc_end[0-9]+:\n', r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_LOONGARCH_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@"?(?P=func)"?\n'
r'(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?'
r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S))
SCRUB_X86_SHUFFLES_RE = ( SCRUB_X86_SHUFFLES_RE = (
re.compile( re.compile(
r'^(\s*\w+) [^#\n]+#+ ((?:[xyz]mm\d+|mem)( \{%k\d+\}( \{z\})?)? = .*)$', r'^(\s*\w+) [^#\n]+#+ ((?:[xyz]mm\d+|mem)( \{%k\d+\}( \{z\})?)? = .*)$',
flags=re.M)) flags=re.M))
SCRUB_X86_SHUFFLES_NO_MEM_RE = ( SCRUB_X86_SHUFFLES_NO_MEM_RE = (
re.compile( re.compile(
r'^(\s*\w+) [^#\n]+#+ ((?:[xyz]mm\d+|mem)( \{%k\d+\}( \{z\})?)? = (?!.*(?:mem)).*)$', r'^(\s*\w+) [^#\n]+#+ ((?:[xyz]mm\d+|mem)( \{%k\d+\}( \{z\})?)? = (?!.*(?:mem)).*)$',
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Linesdef scrub_asm_csky(asm, args):
# Expand the tabs used for indentation. # Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2) asm = string.expandtabs(asm, 2)
# Strip kill operands inserted into the asm. # Strip kill operands inserted into the asm.
asm = common.SCRUB_KILL_COMMENT_RE.sub('', asm) asm = common.SCRUB_KILL_COMMENT_RE.sub('', asm)
# Strip trailing whitespace. # Strip trailing whitespace.
asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm) asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm return asm
def scrub_asm_loongarch(asm, args):
# Scrub runs of whitespace out of the assembly, but leave the leading
# whitespace in place.
asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm)
# Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2)
# Strip trailing whitespace.
asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm
def get_run_handler(triple): def get_run_handler(triple):
target_handlers = { target_handlers = {
'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'arm64_32-apple-ios': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE), 'arm64_32-apple-ios': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE), 'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
'aarch64-apple-darwin': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE), 'aarch64-apple-darwin': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
Show All 22 Lines target_handlers = {
'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE), 'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE), 'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
'lanai': (scrub_asm_lanai, ASM_FUNCTION_LANAI_RE), 'lanai': (scrub_asm_lanai, ASM_FUNCTION_LANAI_RE),
'sparc': (scrub_asm_sparc, ASM_FUNCTION_SPARC_RE), 'sparc': (scrub_asm_sparc, ASM_FUNCTION_SPARC_RE),
's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE), 's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE),
'wasm32': (scrub_asm_wasm32, ASM_FUNCTION_WASM32_RE), 'wasm32': (scrub_asm_wasm32, ASM_FUNCTION_WASM32_RE),
've': (scrub_asm_ve, ASM_FUNCTION_VE_RE), 've': (scrub_asm_ve, ASM_FUNCTION_VE_RE),
'csky': (scrub_asm_csky, ASM_FUNCTION_CSKY_RE), 'csky': (scrub_asm_csky, ASM_FUNCTION_CSKY_RE),
'loongarch32': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE),
'loongarch64': (scrub_asm_loongarch, ASM_FUNCTION_LOONGARCH_RE),
} }
handler = None handler = None
best_prefix = '' best_prefix = ''
for prefix, s in target_handlers.items(): for prefix, s in target_handlers.items():
if triple.startswith(prefix) and len(prefix) > len(best_prefix): if triple.startswith(prefix) and len(prefix) > len(best_prefix):
handler = s handler = s
best_prefix = prefix best_prefix = prefix
Show All 15 Lines