Page MenuHomePhabricator

[clang][driver] Disable non-functional --version option for clang -cc1
ClosedPublic

Authored by ekieri on Mar 23 2022, 12:43 PM.

Details

Summary

This patch removes --version as a clang -cc1 option.

clang --version

and

clang --cc1 -version

remain valid. This behaviour is consistent with clang -cc1as.

Previously, clang -cc1 accepted both --version and -version, but
only -version was acted upon. The call

clang -cc1 --version

stalled without any message: --version was an accepted option but
triggered no action, and the driver waited for standard input.

Diff Detail

Event Timeline

ekieri created this revision.Mar 23 2022, 12:43 PM
Herald added a project: Restricted Project. · View Herald Transcript
ekieri requested review of this revision.Mar 23 2022, 12:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 12:43 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
thakis accepted this revision.Mar 25 2022, 6:06 AM

thanks!

This revision is now accepted and ready to land.Mar 25 2022, 6:06 AM