Page MenuHomePhabricator

ekieri (Emil Kieri)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2021, 1:15 PM (42 w, 3 d)

Recent Activity

Jun 15 2022

ekieri accepted D127821: [NFC][flang] Add the test case for D125371.

Thanks!

Jun 15 2022, 10:20 AM · Restricted Project, Restricted Project

Jun 14 2022

ekieri added a comment to D127601: [flang][OpenMP] Add one semantic check for data-sharing clauses.

I think you can use the WARNING-directives without waiting for D125804. It will take me some time to land it, and I do not think it should block other developments. In the meantime, it would only be helpful if WARNING-directives are included in new (and existing) tests, like you did here. It would, for now, give a false impression of the warnings being tested, but at least they will be in the future (and if it regresses before then, I will notice). Refraining from testing warnings in the meantime comes with the risk of forgetting to add the tests later.

Jun 14 2022, 9:56 AM · Restricted Project, Restricted Project

Jun 8 2022

ekieri added a comment to D127337: [flang][test] Make tests warning-correct for integer division-by-zero.

I post these in a separate patch for the extra visibility, as I would like some input. What do you make of this? resolve37.f90, with the four consecutive WARNING-directives, looks a bit silly, and the repetition is not particularly helpful. But the logic behind each of them is clear (the subexpression in question is marked for each warning). I expect that limiting to one warning per expression would complicate the logic. Would that be worth it, or even desired? Note that integer division-by-zero in a constant expression also triggers an error.

Jun 8 2022, 12:49 PM · Restricted Project, Restricted Project
ekieri requested review of D127337: [flang][test] Make tests warning-correct for integer division-by-zero.
Jun 8 2022, 12:46 PM · Restricted Project, Restricted Project
ekieri added a comment to D126890: [flang][driver] Make `flang-new -fc1` accept MLIR files.

By the way, did you note that the CI has some trouble with the formatting?

Jun 8 2022, 12:41 PM · Restricted Project, Restricted Project
ekieri added a comment to D126890: [flang][driver] Make `flang-new -fc1` accept MLIR files.

Thanks, can I assume that you are OK with this change?

Jun 8 2022, 12:04 PM · Restricted Project, Restricted Project
ekieri added a comment to D126890: [flang][driver] Make `flang-new -fc1` accept MLIR files.

Both tools drive the same set of libraries, but these libraries are very complex (i.e. require a lot of set-up that depends on user input) and the drivers are almost completely separate. It is hard to guarantee that the behavior is consistent without testing with both (in fact, we did see them diverge in the past - that happens when updates are made in one tool, but not in the other).

Jun 8 2022, 9:16 AM · Restricted Project, Restricted Project
ekieri added inline comments to D127207: [flang][driver] Fix support for `-x`.
Jun 8 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

ekieri updated subscribers of D126890: [flang][driver] Make `flang-new -fc1` accept MLIR files.

Is it the right trade-off between test coverage and computational effort to have dual run lines for the tco cases? I would assume that in most cases, what is actually tested will be deferred to the same code by both tools. Could we get almost the same coverage for half the effort by using the one tool for half the tests and the other for the rest, or would we miss something important by doing that?

Jun 7 2022, 12:37 PM · Restricted Project, Restricted Project
ekieri added inline comments to D127207: [flang][driver] Fix support for `-x`.
Jun 7 2022, 11:54 AM · Restricted Project, Restricted Project, Restricted Project

May 28 2022

ekieri updated the summary of D126459: [flang] Make extension explicit: exponent-letter matching kind-param.
May 28 2022, 1:09 PM · Restricted Project, Restricted Project
ekieri committed rGf1983feaa196: [flang] Make extension explicit: exponent-letter matching kind-param (authored by ekieri).
[flang] Make extension explicit: exponent-letter matching kind-param
May 28 2022, 1:07 PM · Restricted Project, Restricted Project
ekieri closed D126459: [flang] Make extension explicit: exponent-letter matching kind-param.
May 28 2022, 1:06 PM · Restricted Project, Restricted Project
ekieri added inline comments to D126459: [flang] Make extension explicit: exponent-letter matching kind-param.
May 28 2022, 1:05 PM · Restricted Project, Restricted Project

May 26 2022

ekieri committed rG4c549a0b593e: [flang][NFC] Make semantics test dosemantics03.f90 warning-correct (authored by ekieri).
[flang][NFC] Make semantics test dosemantics03.f90 warning-correct
May 26 2022, 6:24 AM · Restricted Project, Restricted Project
ekieri closed D126176: [flang][NFC] Make semantics test dosemantics03.f90 warning-correct.
May 26 2022, 6:24 AM · Restricted Project, Restricted Project
ekieri requested review of D126459: [flang] Make extension explicit: exponent-letter matching kind-param.
May 26 2022, 5:03 AM · Restricted Project, Restricted Project

May 22 2022

ekieri requested review of D126176: [flang][NFC] Make semantics test dosemantics03.f90 warning-correct.
May 22 2022, 1:30 PM · Restricted Project, Restricted Project

May 5 2022

ekieri added a comment to D124848: [flang] Make the bash script print short info whenever used.

Sure, if you find my draft message useful, please go ahead. Whether you use it or not, consider me satisfied. But yes, please wait for Steve.

May 5 2022, 12:58 PM · Restricted Project, Restricted Project

May 3 2022

ekieri added a comment to D124848: [flang] Make the bash script print short info whenever used.

Thanks for doing this, would be great if we can reduce the confusion generated by this script. I have almost never used this script myself, and is not really sure what it is for, so I am perhaps not in the best position to comment. But here are my thoughts, for what it is worth:

May 3 2022, 1:00 PM · Restricted Project, Restricted Project
ekieri added a comment to D124664: [flang][driver] Define the default frontend driver triple.

Looks good, thanks!

May 3 2022, 8:53 AM · Restricted Project, Restricted Project

May 2 2022

ekieri committed rG1dd8da2d7c75: [flang] Fix semantics check for RETURN statement (authored by ekieri).
[flang] Fix semantics check for RETURN statement
May 2 2022, 1:07 PM · Restricted Project, Restricted Project
ekieri closed D124732: [flang] Fix semantics check for RETURN statement.
May 2 2022, 1:06 PM · Restricted Project, Restricted Project

May 1 2022

ekieri accepted D124664: [flang][driver] Define the default frontend driver triple.

LGTM, just a small suggestion: Could you add a note about the missing tests (that (and why) they are in D124667) to the commit message?

May 1 2022, 12:28 PM · Restricted Project, Restricted Project
ekieri requested review of D124732: [flang] Fix semantics check for RETURN statement.
May 1 2022, 12:16 AM · Restricted Project, Restricted Project

Apr 26 2022

ekieri added a comment to D124245: [flang][driver] NFC: Make code more in line with LLVM style.

Thanks for addressing my comments!

Apr 26 2022, 12:36 PM · Restricted Project, Restricted Project

Apr 23 2022

ekieri accepted D124245: [flang][driver] NFC: Make code more in line with LLVM style.

Thanks for taking the time to work on quality and compliance! LGTM, but please consider my nits.

Apr 23 2022, 12:00 AM · Restricted Project, Restricted Project

Apr 13 2022

ekieri added inline comments to D123211: [flang][driver] Add support for generating LLVM bytecode files.
Apr 13 2022, 8:17 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

ekieri added inline comments to D123211: [flang][driver] Add support for generating LLVM bytecode files.
Apr 12 2022, 1:35 PM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

ekieri accepted D123211: [flang][driver] Add support for generating LLVM bytecode files.

One nit/question inline, otherwise LGTM.

Apr 11 2022, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

ekieri committed rGda1fc3ae955d: [Driver][NFC] Simplify handling of flags in Options.td (authored by ekieri).
[Driver][NFC] Simplify handling of flags in Options.td
Apr 7 2022, 11:41 AM · Restricted Project, Restricted Project
ekieri closed D123070: [Driver][NFC] Simplify handling of flags in Options.td.
Apr 7 2022, 11:41 AM · Restricted Project, Restricted Project

Apr 6 2022

ekieri added a comment to D123113: [Flang] Add `INTENT` for non-dummy arguments extension.

Ok, good. Then please abandon this revision (Add Action... down by the comment box), so that its status is clear to everybody. Cheers!

Apr 6 2022, 7:36 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

ekieri added reviewers for D123113: [Flang] Add `INTENT` for non-dummy arguments extension: klausler, PeteSteinfeld.

Hi! Thanks for this patch, and for your interest in contributing to Flang!

Apr 5 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
ekieri added a comment to D123070: [Driver][NFC] Simplify handling of flags in Options.td.

Thank you all for the support!

Apr 5 2022, 10:49 AM · Restricted Project, Restricted Project

Apr 4 2022

ekieri added a comment to D123070: [Driver][NFC] Simplify handling of flags in Options.td.

This patch is the result of discussions in https://reviews.llvm.org/D122542

Apr 4 2022, 1:17 PM · Restricted Project, Restricted Project
ekieri updated the summary of D123070: [Driver][NFC] Simplify handling of flags in Options.td.
Apr 4 2022, 1:17 PM · Restricted Project, Restricted Project
ekieri requested review of D123070: [Driver][NFC] Simplify handling of flags in Options.td.
Apr 4 2022, 1:10 PM · Restricted Project, Restricted Project

Apr 1 2022

ekieri added inline comments to D122799: [flang] Update the conversion code for fir.coordinate_of.
Apr 1 2022, 7:36 AM · Restricted Project, Restricted Project

Mar 28 2022

ekieri committed rG577827cbbf10: [flang][driver] Make --version and -version consistent with clang (authored by ekieri).
[flang][driver] Make --version and -version consistent with clang
Mar 28 2022, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
ekieri closed D122542: [flang][driver] Make --version and -version consistent with clang.
Mar 28 2022, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
ekieri added inline comments to D122542: [flang][driver] Make --version and -version consistent with clang.
Mar 28 2022, 11:27 AM · Restricted Project, Restricted Project, Restricted Project
ekieri updated the summary of D122542: [flang][driver] Make --version and -version consistent with clang.
Mar 28 2022, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
ekieri updated the diff for D122542: [flang][driver] Make --version and -version consistent with clang.

Address review comment.
Fix typo in summary.

Mar 28 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2022

ekieri requested review of D122542: [flang][driver] Make --version and -version consistent with clang.
Mar 27 2022, 12:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2022

ekieri committed rG35b89bc24ca5: [clang][driver] Disable non-functional --version option for clang -cc1 (authored by ekieri).
[clang][driver] Disable non-functional --version option for clang -cc1
Mar 25 2022, 11:06 AM · Restricted Project, Restricted Project
ekieri closed D122344: [clang][driver] Disable non-functional --version option for clang -cc1.
Mar 25 2022, 11:05 AM · Restricted Project, Restricted Project

Mar 23 2022

ekieri requested review of D122344: [clang][driver] Disable non-functional --version option for clang -cc1.
Mar 23 2022, 12:43 PM · Restricted Project, Restricted Project

Mar 16 2022

ekieri committed rGb85922cde6e3: [flang] Include missing internal interfaces in .mod files (authored by ekieri).
[flang] Include missing internal interfaces in .mod files
Mar 16 2022, 1:46 PM · Restricted Project, Restricted Project
ekieri closed D121738: [flang] Include missing internal interfaces in .mod files.
Mar 16 2022, 1:46 PM · Restricted Project, Restricted Project
ekieri updated the diff for D121738: [flang] Include missing internal interfaces in .mod files.

Thanks for the suggestion, Pete!

Mar 16 2022, 12:55 PM · Restricted Project, Restricted Project
ekieri updated the diff for D121738: [flang] Include missing internal interfaces in .mod files.

Hi Andrzej, many thanks for all the encouragement! Yes, I added you more
like a cc (could rather have used that, I realise) as you did the
initial triage.

Mar 16 2022, 10:25 AM · Restricted Project, Restricted Project

Mar 15 2022

ekieri updated the diff for D121738: [flang] Include missing internal interfaces in .mod files.

Sorry about that ...

Mar 15 2022, 3:29 PM · Restricted Project, Restricted Project
ekieri added a comment to D121738: [flang] Include missing internal interfaces in .mod files.

Right, here is a first attempt at fixing [1]. Please check in that my intent, as described in the above summary, is the desired behaviour.

Mar 15 2022, 1:45 PM · Restricted Project, Restricted Project
ekieri requested review of D121738: [flang] Include missing internal interfaces in .mod files.
Mar 15 2022, 1:43 PM · Restricted Project, Restricted Project

Dec 13 2021

ekieri accepted D113086: [flang] Add a semantics test for co_reduce.

I'll try to find time for another look within the next few days. Please don't forget to answer @clementval 's inline comment, and mark mine as done if you fixed it. And I would prefer if you add a TODO comment in the file header about tests for 'result_image', 'stat', and 'errmsg'.

Dec 13 2021, 1:51 PM · Restricted Project, Restricted Project

Dec 9 2021

ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

I'll try to find time for another look within the next few days. Please don't forget to answer @clementval 's inline comment, and mark mine as done if you fixed it. And I would prefer if you add a TODO comment in the file header about tests for 'result_image', 'stat', and 'errmsg'.

Dec 9 2021, 2:05 PM · Restricted Project, Restricted Project

Dec 5 2021

ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

Thanks for addressing my comments! I noted an oversight inline, and wonder about the intended test coverage, otherwise this looks good I think.

Dec 5 2021, 1:18 PM · Restricted Project, Restricted Project

Dec 1 2021

ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

It would be nice with a comment citing where in the standard the interface of this intrinsic is specified.

Are you (or do you know of someone who is) planning to write the actual semantics checks as well in the near future? I am a little concerned that otherwise the developer who does that one day will be unaware of these tests, and implements additional tests of their own, leaving your tests with XFAIL.

Also, your test contains trailing whitespace. Is this intentional? The coding standards [1] discourages that, and while they primarily concern the c++ code, the argument provided is no less valid for test cases in fortran. On the other hand, @klausler made the (also valid) argument in D113077 that variations in style improves test coverage of the parser. I am fine with you doing it either way, but encourage you to make a conscious decision about it.

[1] https://llvm.org/docs/CodingStandards.html#whitespace

@ekieri, in response to one of your questions, I am currently working on adding the collectives to flang/lib/Evaluate/intrinsics.cpp. When I submit patches, they will include changes to the corresponding collective test to remove the XFAIL directive. However, regardless of who works on the collectives, when a test with an XFAIL directive does not fail, the test will be listed as Unexpectedly Passed when running the test suite. This should bring any developer's attention to these tests that @rouson is submitting.

Dec 1 2021, 1:20 PM · Restricted Project, Restricted Project

Nov 21 2021

ekieri added inline comments to D113086: [flang] Add a semantics test for co_reduce.
Nov 21 2021, 12:55 PM · Restricted Project, Restricted Project
ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

It would be nice with a comment citing where in the standard the interface of this intrinsic is specified.

Nov 21 2021, 12:44 PM · Restricted Project, Restricted Project

Nov 18 2021

ekieri added a comment to D113084: [flang] Add a semantics test for co_broadcast.

Can you please base the patch on main? This diff looks like a small typo fix, but the whole file is new. That would also help the pre-merge tester to apply your patch.

Nov 18 2021, 8:22 AM · Restricted Project, Restricted Project
ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

@kiranchandramohan with your approval and that of @ktras, I just pushed differential D113076. Could you review and approve this one along with differential D113077, D113083, and D113084? Also, could you point me to a policy on what approvals are needed in order to push commits to main?

Nov 18 2021, 12:52 AM · Restricted Project, Restricted Project

Nov 14 2021

ekieri added a comment to D113706: [flang] Allow implicit procedure pointers to associate with explicit procedures.

Standard conformance notwithstanding, a procedure pointer should not be allowed to be associated with any target procedure (or pointer) that is not callable via the pointer after the association.

Nov 14 2021, 1:30 PM · Restricted Project, Restricted Project
ekieri added a comment to D113706: [flang] Allow implicit procedure pointers to associate with explicit procedures.

Thanks for your efforts! Looks good to me, but please wait for Peter. I left a few suggestions inline that you could consider.

Nov 14 2021, 1:24 PM · Restricted Project, Restricted Project

Nov 11 2021

ekieri added a comment to D113706: [flang] Allow implicit procedure pointers to associate with explicit procedures.

I agree with your interpretation of paragraph 3 (and Peter's of paragraph 4). However, both gfortran and nvfortran allow pointers with explicit interface to target procedures with implicit interface, if my test case is correct. Perhaps it could be useful to test with other compilers? And _if_ most of them take the more liberal standpoint on this, do we keep to the standard, or is it more user-friendly to implement an established extension? Or could the standard be read differently? No strong opinion from my side (but my instinct is to stay with the standard), just wanted to bring this to your attention.

Nov 11 2021, 2:21 PM · Restricted Project, Restricted Project

Nov 9 2021

ekieri committed rG384b4e0d332e: [flang] Fix error in characteristics check at procedure pointer assignment (authored by ekieri).
[flang] Fix error in characteristics check at procedure pointer assignment
Nov 9 2021, 9:47 AM
ekieri closed D113368: [flang] Fix error in characteristics check at procedure pointer assignment.
Nov 9 2021, 9:47 AM · Restricted Project, Restricted Project

Nov 7 2021

ekieri requested review of D113368: [flang] Fix error in characteristics check at procedure pointer assignment.
Nov 7 2021, 12:06 PM · Restricted Project, Restricted Project

Oct 28 2021

ekieri added a comment to D112381: [flang] Checks for pointers to intrinsic functions.

That worked out nicely, thanks a lot for all your help!

Oct 28 2021, 6:15 AM · Restricted Project, Restricted Project
ekieri committed rG848cca6c5bf0: [flang] Checks for pointers to intrinsic functions (authored by ekieri).
[flang] Checks for pointers to intrinsic functions
Oct 28 2021, 3:47 AM
ekieri closed D112381: [flang] Checks for pointers to intrinsic functions.
Oct 28 2021, 3:47 AM · Restricted Project, Restricted Project

Oct 27 2021

ekieri added a comment to D112381: [flang] Checks for pointers to intrinsic functions.

Am I not supposed to havet a track record within the project to get commit access? The policy you linked suggests that. This is my first contribution to llvm.

@ekieri, I've discussed this with Peter, and we both think that the best thing is for you to get commit access and do the commit yourself.

Oct 27 2021, 12:04 PM · Restricted Project, Restricted Project

Oct 25 2021

ekieri added a comment to D112381: [flang] Checks for pointers to intrinsic functions.

Am I not supposed to havet a track record within the project to get commit access? The policy you linked suggests that. This is my first contribution to llvm.

Oct 25 2021, 1:43 PM · Restricted Project, Restricted Project
ekieri added a comment to D112381: [flang] Checks for pointers to intrinsic functions.

Thanks @klausler for your comments!

Oct 25 2021, 1:00 PM · Restricted Project, Restricted Project
ekieri updated the diff for D112381: [flang] Checks for pointers to intrinsic functions.

Address comments from Peter

Oct 25 2021, 12:51 PM · Restricted Project, Restricted Project
ekieri added a comment to D112381: [flang] Checks for pointers to intrinsic functions.

Thanks @PeteSteinfeld for the review! I also added a comment for C1519 (initialisation of procedure pointers). All aspects of those constraints are not tested, but I intend to continue working towards that in subsequent patches.

Oct 25 2021, 8:18 AM · Restricted Project, Restricted Project
ekieri updated the diff for D112381: [flang] Checks for pointers to intrinsic functions.

Address comment from Pete

Oct 25 2021, 8:16 AM · Restricted Project, Restricted Project

Oct 24 2021

ekieri requested review of D112381: [flang] Checks for pointers to intrinsic functions.
Oct 24 2021, 9:41 AM · Restricted Project, Restricted Project