This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Add AssertAlign to AddNodeIDCustom so that it will CSE properly.
ClosedPublic

Authored by craig.topper on Mar 22 2022, 7:44 PM.

Details

Summary

The alignment needs to be part of the folding set hash. This is
handled by getAssertAlign when nodes are created, but needs to repeated here.

No test case as I found it as part of a very early experimental patch.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 22 2022, 7:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 7:44 PM
craig.topper requested review of this revision.Mar 22 2022, 7:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 7:44 PM
Herald added a subscriber: wdng. · View Herald Transcript
spatel accepted this revision.Mar 24 2022, 4:56 AM

LGTM

This revision is now accepted and ready to land.Mar 24 2022, 4:56 AM
This revision was landed with ongoing or failed builds.Mar 24 2022, 9:07 AM
This revision was automatically updated to reflect the committed changes.