This is an archive of the discontinued LLVM Phabricator instance.

[Headers][X86] Add -O0 assembly tests for intrinsics.
ClosedPublic

Authored by ab on Aug 20 2015, 1:35 PM.

Details

Summary

We agreed in D10555 that, as long as we don't affect -O0 codegen too much, it's OK to use native constructs rather than intrinsics. Let's test that, starting with AVX2 here. I'll add others if people are fine with the idea, or have objections to the mixed testing.

Diff Detail

Repository
rL LLVM

Event Timeline

ab updated this revision to Diff 32732.Aug 20 2015, 1:35 PM
ab retitled this revision from to [Headers][X86] Add -O0 assembly tests for intrinsics..
ab updated this object.
ab added reviewers: spatel, RKSimon.
ab added subscribers: cfe-commits, chandlerc, silvas, qcolombet.
RKSimon edited edge metadata.Aug 20 2015, 2:05 PM

Definitely like this idea - hopefully it'll make it safer to remove unnecessary builtins.

avx2-builtins-codegen.c
182 ↗(On Diff #32732)

Please can you add a comment explaining the FIXME?

RKSimon accepted this revision.Aug 22 2015, 7:14 AM
RKSimon edited edge metadata.

LGTM with a suitable FIXME comment. Email me if you want to split the work on adding this to the other SSE/AVX builtin tests.

This revision is now accepted and ready to land.Aug 22 2015, 7:14 AM
This revision was automatically updated to reflect the committed changes.
ab added a comment.Aug 25 2015, 4:11 PM

Thanks Simon! Replaced the FIXMEs with proper tests and committed.

Whenever I have time I'll have a look at the others, filed PR24580.