Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[mlir] Add support for the nest attribute to the LLVM-IR dialect conversion.

Authored by schweitz on Mar 17 2022, 1:44 PM.

Diff Detail

Event Timeline

schweitz created this revision.Mar 17 2022, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2022, 1:44 PM
schweitz requested review of this revision.Mar 17 2022, 1:44 PM

LGTM. Can you just fix the clang-format issue?

ftynse accepted this revision.Mar 18 2022, 2:43 AM
ftynse added inline comments.

Ideally, we would move these to the verifier of the LLVM dialect. Given the consistency with the other attributes, this is something to do in a separate patch.

This revision is now accepted and ready to land.Mar 18 2022, 2:43 AM
This revision was landed with ongoing or failed builds.Mar 18 2022, 8:15 AM
This revision was automatically updated to reflect the committed changes.