This is an archive of the discontinued LLVM Phabricator instance.

Differential D121857

[scudo] Don't assume preprocessor macro is defined
ClosedPublic

Authored by ddcc on Mar 16 2022, 2:11 PM.

Details

Reviewers
vitalybuka
eugenis
cryptoad
mcgrathr
hctim
Commits
rG26a5f9bd0302: [scudo] Don't assume preprocessor macro is defined

Diff Detail

Event Timeline

ddcc created this revision.Mar 16 2022, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 2:11 PM
ddcc requested review of this revision.Mar 16 2022, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 2:11 PM
Harbormaster completed remote builds in B154709: Diff 415981.Mar 16 2022, 2:42 PM
vitalybuka added inline comments.Mar 16 2022, 5:14 PM
compiler-rt/lib/scudo/standalone/platform.h
40

isn't this evaluates to 0 if not defined?

ddcc added inline comments.Mar 17 2022, 10:21 AM
compiler-rt/lib/scudo/standalone/platform.h
40

Yes, but it emits a warning under -Wundef, and it's only ever supposed to be defined with value 1, so it's better to just check whether it's defined.

vitalybuka accepted this revision.Mar 17 2022, 12:32 PM
This revision is now accepted and ready to land.Mar 17 2022, 12:32 PM
Closed by commit rG26a5f9bd0302: [scudo] Don't assume preprocessor macro is defined (authored by ddcc). · Explain WhyMar 18 2022, 12:54 PM
This revision was automatically updated to reflect the committed changes.
ddcc added a commit: rG26a5f9bd0302: [scudo] Don't assume preprocessor macro is defined.

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
2 lines

Diff 416579

compiler-rt/lib/scudo/standalone/platform.h

Show All 31 Lines
#endif #endif
#if defined(__TRUSTY__) #if defined(__TRUSTY__)
#define SCUDO_TRUSTY 1 #define SCUDO_TRUSTY 1
#else #else
#define SCUDO_TRUSTY 0 #define SCUDO_TRUSTY 0
#endif #endif
#if __LP64__ #if defined(__LP64__)
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

isn't this evaluates to 0 if not defined?

vitalybuka: isn't this evaluates to 0 if not defined?
ddccAuthorUnsubmitted
Done
ReplyInline Actions

Yes, but it emits a warning under -Wundef, and it's only ever supposed to be defined with value 1, so it's better to just check whether it's defined.

ddcc: Yes, but it emits a warning under `-Wundef`, and it's only ever supposed to be defined with…
#define SCUDO_WORDSIZE 64U #define SCUDO_WORDSIZE 64U
#else #else
#define SCUDO_WORDSIZE 32U #define SCUDO_WORDSIZE 32U
#endif #endif
#if SCUDO_WORDSIZE == 64U #if SCUDO_WORDSIZE == 64U
#define FIRST_32_SECOND_64(a, b) (b) #define FIRST_32_SECOND_64(a, b) (b)
#else #else
Show All 32 Lines