Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D121644

[llvm-objcopy] Simplify CompressedSection creation. NFC
ClosedPublic
Actions

Authored by MaskRay on Mar 14 2022, 2:51 PM.

Details

Reviewers
jhenderson
alexander-shaposhnikov
Commits
rGcce352102001: [llvm-objcopy] Simplify CompressedSection creation. NFC
Summary

Remove Expected<CompressedSection> factory functions in favor of constructors
now that zlib::compress returns void (D121512).

Diff Detail

Event Timeline

MaskRay created this revision.Mar 14 2022, 2:51 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptMar 14 2022, 2:51 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: abrachet, hiraditya, emaste. · View Herald Transcript
MaskRay requested review of this revision.Mar 14 2022, 2:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 2:51 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B154199: Diff 415239.Mar 14 2022, 3:52 PM
jhenderson accepted this revision.Mar 14 2022, 11:06 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2022, 11:06 PM
This revision was landed with ongoing or failed builds.Mar 14 2022, 11:15 PM
Closed by commit rGcce352102001: [llvm-objcopy] Simplify CompressedSection creation. NFC (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGcce352102001: [llvm-objcopy] Simplify CompressedSection creation. NFC.

Revision Contents
Changeset List

PathSize
llvm/
lib/
ObjCopy/
ELF/
8 lines
15 lines
20 lines

Diff 415324

View Options

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

Loading...
View Options

llvm/lib/ObjCopy/ELF/ELFObject.h

Loading...
View Options

llvm/lib/ObjCopy/ELF/ELFObject.cpp

Loading...