This is an archive of the discontinued LLVM Phabricator instance.

Differential D121611

[flang] Lower format statement
ClosedPublic

Authored by clementval on Mar 14 2022, 9:16 AM.

Details

Reviewers
jeanPerier
PeteSteinfeld
schweitz
svedanayagam
klausler
Commits
rGd8222d91c6f4: [flang] Lower format statement
Summary

This patch lowers the format statement.

Diff Detail

Event Timeline

clementval created this revision.Mar 14 2022, 9:16 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 14 2022, 9:16 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Mar 14 2022, 9:16 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 14 2022, 9:16 AM
Harbormaster completed remote builds in B154118: Diff 415115.Mar 14 2022, 9:33 AM
PeteSteinfeld accepted this revision.Mar 14 2022, 9:54 AM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Mar 14 2022, 9:54 AM
Closed by commit rGd8222d91c6f4: [flang] Lower format statement (authored by clementval). · Explain WhyMar 14 2022, 10:15 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGd8222d91c6f4: [flang] Lower format statement.

Revision Contents

PathSize
flang/
lib/
Lower/
5 lines
test/
Lower/
59 lines

Diff 415141

flang/lib/Lower/Bridge.cpp

Show First 20 Lines • Show All 1,910 Lines • ▼ Show 20 Lines const Fortran::semantics::Symbol &symbol =
*std::get<Fortran::parser::Name>(stmt.t).symbol; *std::get<Fortran::parser::Name>(stmt.t).symbol;
mlir::Location loc = toLocation(); mlir::Location loc = toLocation();
mlir::Value labelValue = builder->createIntegerConstant( mlir::Value labelValue = builder->createIntegerConstant(
loc, genType(symbol), std::get<Fortran::parser::Label>(stmt.t)); loc, genType(symbol), std::get<Fortran::parser::Label>(stmt.t));
builder->create<fir::StoreOp>(loc, labelValue, getSymbolAddress(symbol)); builder->create<fir::StoreOp>(loc, labelValue, getSymbolAddress(symbol));
} }
void genFIR(const Fortran::parser::FormatStmt &) { void genFIR(const Fortran::parser::FormatStmt &) {
TODO(toLocation(), "FormatStmt lowering"); // do nothing.
// FORMAT statements have no semantics. They may be lowered if used by a
// data transfer statement.
} }
void genFIR(const Fortran::parser::PauseStmt &stmt) { void genFIR(const Fortran::parser::PauseStmt &stmt) {
genPauseStatement(*this, stmt); genPauseStatement(*this, stmt);
} }
void genFIR(const Fortran::parser::FailImageStmt &stmt) { void genFIR(const Fortran::parser::FailImageStmt &stmt) {
TODO(toLocation(), "FailImageStmt lowering"); TODO(toLocation(), "FailImageStmt lowering");
▲ Show 20 Lines • Show All 384 Lines • Show Last 20 Lines

flang/test/Lower/format-statement.f90

  • This file was added.
! RUN: bbc %s -o - | FileCheck %s
! CHECK-LABEL: func @_QPformatassign
subroutine formatAssign(flag1, flag2, flag3)
real :: pi
integer :: label
logical :: flag1, flag2, flag3
! CHECK-DAG: %[[ONE:.*]] = arith.constant 100 : i32
! CHECK-DAG: %[[TWO:.*]] = arith.constant 200 : i32
if (flag1) then
assign 100 to label
else
assign 200 to label
end if
! CHECK: cond_br %{{.*}}, ^bb[[BLK1:.*]], ^bb[[BLK2:.*]]
! CHECK: ^bb[[BLK1]]:
! CHECK: fir.store %[[ONE]]
! CHECK: br ^bb[[END_BLOCK:.*]]
! CHECK: ^bb[[BLK2]]:
! CHECK: fir.store %[[TWO]]
! CHECK: br ^bb[[END_BLOCK]]
! CHECK: ^bb[[END_BLOCK]]
! CHECK: fir.call @{{.*}}BeginExternalFormattedOutput
! CHECK: fir.call @{{.*}}OutputAscii
! CHECK: fir.call @{{.*}}OutputReal32
! CHECK: fir.call @{{.*}}EndIoStatement
pi = 3.141592653589
write(*, label) " PI=", pi
! CHECK: fir.call @{{.*}}BeginExternalFormattedOutput
! CHECK: fir.call @{{.*}}OutputAscii
! CHECK: fir.call @{{.*}}OutputReal32
! CHECK: fir.call @{{.*}}EndIoStatement
if (flag2) write(*, label) "2PI=", 2*pi
if (flag1 .and. flag2 .and. flag3) then
assign 100 to label
else
assign 200 to label
end if
if (flag3) then
! CHECK: fir.call @{{.*}}BeginExternalFormattedOutput
! CHECK: fir.call @{{.*}}OutputAscii
! CHECK: fir.call @{{.*}}OutputReal32
! CHECK: fir.call @{{.*}}EndIoStatement
write(*, label) "3PI=", 3*pi
endif
100 format (A, F10.3)
200 format (A,E8.1)
300 format (A, E4.2)
end subroutine
! CHECK-LABEL: func @_QQmain
call formatAssign(.true., .true., .true.)
print*
call formatAssign(.true., .false., .true.)
end